Fixes #635: added missing Default

[jenxie]

Fixes #635: Added missing Default to data in resourceNetboxCustomField and resourceNetboxCustomFieldCreate

default value is now created correctly:

{
      ...
      "id": 1,
      "url": "http://localhost:8001/api/extras/custom-fields/1/",
      "display": "test",
      ...
      "data_type": "string",
      "name": "test",
      "label": "test",
      ...
      "default": "\"default value ignored\"",
      "weight": 100,
      ...
    }
  ]
}

UI screenshot:

[jenxie]

Failed test:

=== NAME  TestAccNetboxDeviceInterfacesDataSource_basic
    testing_new.go:85: Error running post-test destroy, there may be dangling resources: exit status 1
        
        Error: 0xc00304b4a8 (*interface {}) is not supported by the TextConsumer, can be resolved by supporting TextUnmarshaler interface
        
--- FAIL: TestAccNetboxDeviceInterfacesDataSource_basic (8.18s)

seems fine running it locally:

jenxie/terraform-provider-netbox > issue-635 <]$ TEST_FUNC=TestAccNetboxDeviceInterfacesDataSource_basic make testacc-specific-test
⌛ Startup acceptance tests on http://localhost:8001 with version v4.0.11
⌛ Testing function TestAccNetboxDeviceInterfacesDataSource_basic
TF_ACC=1 go test -timeout 20m -v -cover netbox/*.go -run TestAccNetboxDeviceInterfacesDataSource_basic
=== RUN   TestAccNetboxDeviceInterfacesDataSource_basic
=== PAUSE TestAccNetboxDeviceInterfacesDataSource_basic
=== CONT  TestAccNetboxDeviceInterfacesDataSource_basic
--- PASS: TestAccNetboxDeviceInterfacesDataSource_basic (13.52s)
PASS
coverage: 8.3% of statements
ok  	command-line-arguments	13.534s	coverage: 8.3% of statements

[fbreckle]

Please add a test that uses this feature. You will probably see that it will fail because you are not updating the schema.

[jenxie]

Please add a test that uses this feature. You will probably see that it will fail because you are not updating the schema.

Thank you for pointing that out.

Added the test, I believe the schema update was already done beforehand at line 60:

			"default": {
				Type:     schema.TypeString,
				Optional: true,
			},

Hence I'm not getting an error after adding the test (however, removing it makes the test fail).

Running the full suite of acceptance tests with make testacc completed without any errors

PASS
coverage: 75.3% of statements
ok  	command-line-arguments	709.561s	coverage: 75.3% of statements

Hopefully I haven't misunderstood it completely :)