Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Survey refactor expansion UI changes #933

Commits on Mar 17, 2023

  1. Left align enketo-notes-list labels

    main.diary.css
    - Increased the left and right padding for .notes-list by 10px
    - Removed the place-items: center as it was overriding the left alignment
    - Added a new style called notes-list-label which aligns the text to the left
    
    place_list_item.html
    - Removed the in-element styling for diary cards because this is now handled with the css
    
    notes_list.html
    - The notes-list-label class is not being used by the notes-list label field to left align it
    sebastianbarry committed Mar 17, 2023
    Configuration menu
    Copy the full SHA
    f158ce6 View commit details
    Browse the repository at this point in the history
  2. Add delete entry confirm popup

    enketo-notes-list.js
    - Added $ionicPopup
    - Added a new confirmDeleteEntry which first confirms you wish to delete, then calls the deleteEntry function
    
    delete-entry.html
    - Contains the template for the confirm delete popup
    
    notes_list.html
    - changed the trash can button to call confirmDeleteEntry() instead of going directly to deleteEntry()
    sebastianbarry committed Mar 17, 2023
    Configuration menu
    Copy the full SHA
    94a8012 View commit details
    Browse the repository at this point in the history

Commits on Mar 18, 2023

  1. notes list CSS patch-up

    Since we will left-align the label, we must remove the horizontal justification, but we still want to keep the vertical alignment in notes-list-entry. To do this, we'll use align-items instead of place-items
    (place-items is shorthand for both justify-items and align-items)
    
    Also, no need to create a whole new class for this. Let's just select the <b> inside of `.notes-list-entry` and add a helpful comment so we know what it refers to
    JGreenlee committed Mar 18, 2023
    Configuration menu
    Copy the full SHA
    c8b0a3d View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    418370c View commit details
    Browse the repository at this point in the history