Add start time, end time, and date to each Place card #937
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
infinite_scroll_list.js - Increased the default height of the place cards in getCardHeight() by 82px - Added a check that if a place does not have a display_end_time, we create a display_end_time to be the end of the day place_list_item.html - Added place start time tag - Added place display date to be centered above the place name - Added place end time tag
|
@shankari here is the new PR for sebastianbarry#8 I also found a place to make the code better and did so |
|
Testing:
|
|
@JGreenlee you might want to merge this as well |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
infinite_scroll_list.js
place_list_item.html