Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup (Server) #1 - Tasks: A-2, 6, 7, 8 #983

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Commits on Sep 21, 2024

  1. Task A-6: Switching to step outputs instead of GITHUB_ENV

    Refer to details in cleanup issue:
    Task A-6: e-mission/e-mission-docs#1082 (comment)
    Mahadik, Mukul Chandrakant authored and Mahadik, Mukul Chandrakant committed Sep 21, 2024
    Configuration menu
    Copy the full SHA
    33bd8d5 View commit details
    Browse the repository at this point in the history
  2. Task A-2: Storing latest tag in .env file + Task A-8: Prefix branch name

    Refer to details in cleanup issue:
    Task A-2: e-mission/e-mission-docs#1082 (comment)
    
    Storing server tag as well so that artifacts are not needed.
    Can also remove image tag passed as input in Workflow dispatch POST request.
    Workflow input also removed in dashboard workflows
    
    For now not removing artifacts until the internal script is updated to handle this change.
    
    ----
    
    Task A-8: Prefixing branch name to the docker tag along with the date.
    In the internal script we will not need to maintain the different branch lists as the images will be completely tagged in the external workflows themselves.
    We can simply use the tags without modifications then.
    
    For now, not prefixing the tag to the artifact since we will be removing the artifact anyways.
    And current internal script works with artifacts.
    Once I update the internal script, will come back and remove artifacts.
    Mahadik, Mukul Chandrakant authored and Mahadik, Mukul Chandrakant committed Sep 21, 2024
    Configuration menu
    Copy the full SHA
    96a8213 View commit details
    Browse the repository at this point in the history
  3. Task A-7: Removed certificates from external Dockerfile; added intern…

    …ally
    
    Refer to issue comment for details:
    Task A-7: e-mission/e-mission-docs#1082 (comment)
    
    The certificates are relevant to our internal AWS configuration and not needed externally.
    They can be present externally too without having any major effect.
    But removing them helps keeping the base image clean.
    Additionally, anyone working with the code can customize with their own certificates if needed or adopt an approach which doesn't even need certificates in the first place.
    Mahadik, Mukul Chandrakant authored and Mahadik, Mukul Chandrakant committed Sep 21, 2024
    Configuration menu
    Copy the full SHA
    c1917c4 View commit details
    Browse the repository at this point in the history
  4. Task A-2: Added .env file initialized with the current latest tag

    Mahadik, Mukul Chandrakant authored and Mahadik, Mukul Chandrakant committed Sep 21, 2024
    Configuration menu
    Copy the full SHA
    f2f344c View commit details
    Browse the repository at this point in the history

Commits on Sep 23, 2024

  1. Task A-2: Removed artifact upload ; internal script updated

    Internal script updated as well.
    Internal PR must be merged as well once these external PR changes merged.
    Mahadik, Mukul Chandrakant authored and Mahadik, Mukul Chandrakant committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    3a01028 View commit details
    Browse the repository at this point in the history