small adaptions #582
Merged
small adaptions #582
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hotfix 0.8.4
- 2 function calls to connectivity check and pit reduction in case of "all" mode - result extraction from active pit to pit done after both calculations separately - all result extraction functions (also for all components) must consider that the connectivity lookups now differ between hydraulics and thermal calculation
- the full graph search is only performed if the check_connectivity option is set - if it is not set, a simple sum_by_group only sets nodes oos that don't have a hydraulic connection to other nodes --> more consistent with the idea behind the option and more performant
- implementation for connectivity in heat mode without check_connectivity option still had errors that were fixed (no return value, wrong comparison base) - tests for connectivity had to be changed, as now p_bar is not null anymore if hydraulics connectivity is given, but not thermal - added test for thermal connectivity without option connectivity_check, but with node that is disconnected wrt. hydraulics
- do not return connected lookup into the pipeflow function, but just leave it inside the lookups - write this lookup in the connectivity function, not in reduce_pit - added some comments and docstrings
* fix: consider ambient pressure in calc. of compression work * fix: consider rel. pressure when getting compressibility values * fix: calculation of kappa instead of 1.4 assumption * proper pandapower Version handling in GHA (reg.Python 3.7) * Update pump_component.py * pump std type from_list now returns the std type * Update run_tests_develop.yml * fix: calculation of compression power, add test * fix np.bool error * install correct pandapower version for tutorial test in Python 3.7 * fix GHA script for Master * replaced references to python-igraph as recommended in e2nIEE#547 (e2nIEE#548) * add example nets of the version * increase version number --------- Co-authored-by: dlohmeier <[email protected]>
# Conflicts: # .github/workflows/release.yml # .github/workflows/run_tests_develop.yml # .github/workflows/run_tests_master.yml # CHANGELOG.rst # pandapipes/pipeflow.py
merge master version 0.8.5 into develop
* update example nets
remove travis badge
* REMOVE Python 3.7 from test pipeline due to inconsistencies with pandapower --------- Co-authored-by: Jolando Kisse <[email protected]>
# Conflicts: # .github/workflows/release.yml # .github/workflows/run_tests_develop.yml # .github/workflows/run_tests_master.yml
merge master into develop (hot fix 0.8.5)
# Conflicts: # CHANGELOG.rst
extend the toolbox function get_internal_tables_pandas such that the overridden indices are derived from the idx_node and idx_branch file directly, so that the lookups don't have to be updated with version changes
* adapted the heat exchanger creation in the stanet converter - if required by user, the flow through heat exchangers is stored in the pandapipes net - added qext_w from stanet - no filtering for connections in heat exchangers (not clear what that was supposed to do, but created errors) - additionally save temperature results for stanet nodes * added heat transfer coefficient to pipes in stanet converter * added external temperature to pipe creation functions * renamed function to create heat exchangers within stanet converter * made TU argument optional in pipe creation of stanet converter (only if available in stanet table) * added changelog entry
Biomethane (bis)
…pipes were considered. Adapted it accordingly that any branch component is considered.
…andapipes into global_thermal
calling 'calculate_derivatives_thermal' once
…data Bugfix/generic geodata
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## transient_heat_transfer #582 +/- ##
=========================================================
Coverage 78.84% 78.85%
=========================================================
Files 98 98
Lines 6945 7071 +126
=========================================================
+ Hits 5476 5576 +100
- Misses 1469 1495 +26 ☔ View full report in Codecov by Sentry. |
added 7 commits
December 15, 2023 08:37
…nsfer # Conflicts: # pandapipes/component_models/abstract_models/branch_models.py # pandapipes/component_models/component_toolbox.py # pandapipes/component_models/junction_component.py # pandapipes/idx_branch.py # pandapipes/pf/pipeflow_setup.py # pandapipes/pipeflow.py
…to transient_heat_transfer # Conflicts: # pandapipes/component_models/abstract_models/branch_models.py # pandapipes/component_models/circulation_pump_pressure_component.py # pandapipes/component_models/heat_exchanger_component.py # pandapipes/component_models/pump_component.py # pandapipes/idx_branch.py # pandapipes/pf/derivative_calculation.py # pandapipes/pf/result_extraction.py # pandapipes/pipeflow.py
…enDrauz/pandapipes into transient_heat_transfer
SimonRubenDrauz
merged commit 0f2f3b5
into
e2nIEE:transient_heat_transfer
12 of 13 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.