Change API for PCRGlobWB model class #85
Conversation
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
This reverts commit a9cc9d3.
Co-authored-by: Stefan Verhoeven <[email protected]>
|
@sverhoeven made some more changes, a.o. I reduced the number of configurable parameters (discussed with Niels a while ago). Could I bother you with another round? |
ewatercycle/models/pcrglobwb.py
Outdated
| raise ValueError( | ||
| "Couldn't spawn the singularity container within allocated" | ||
| " time limit (15 seconds). You may try building it with " | ||
| f"`!singularity run docker://{self.docker_image}` and try " |
There was a problem hiding this comment.
When I got this exception in the example notebook, the building of the Singularity image kept going (as evident from the Jupyter log). So I let that complete and then ran setup again.
The singularity run docker://ewatercycle/pcrg-grpc4bmi:setters will run forever as it starts a BMI server. My suggestion would be to run singularity exec docker://ewatercycle/pcrg-grpc4bmi:setters run-bmi-server -h as it will show some help and then immediately exit.
Also having a ! assumes that the error was thrown in a notebook. I don't think its wise to presume that and would remove the !.
The last sentence assumes the system admin has diverted the SINGULARITY_CACHEDIR to a shared location instead of the default ~/.singularity. This is not possible according to https://singularity.hpcng.org/user-docs/3.7/build_env.html#sec-cache
There was a problem hiding this comment.
Aii, that's a good point. Maybe we cannot use the docker:// syntax after all then, if we want the admin to manage the containers on the system.
For now I've wrapped the whole container startup in a try/except block and adapted the message.
|
SonarCloud Quality Gate failed. |
PCRGlobWBParameterSetandPCRGlobWBForcingclassesversion,parameter_setandforcinginputs