TODOs

eWaterCycle · Oct 18, 2023 · ffbe702 · ffbe702
1 parent 05e1b47
commit ffbe702
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 0 deletions.
diff --git a/test/heat-images/c-julia/Dockerfile b/test/heat-images/c-julia/Dockerfile
@@ -69,6 +69,7 @@ FROM julia:bullseye AS jldeps
 RUN julia -e 'using Pkg; Pkg.add(url="https://github.com/csdms/bmi-example-julia.git",rev="80c34b4f2217599e600fe9372b1bae50e1229edf")' && \
   julia -e 'using Pkg; Pkg.add("BasicModelInterface")'
 
+# TODO use config file from outside container
 RUN curl -L https://github.com/csdms/bmi-example-julia/raw/main/example/heat.toml > /usr/local/share/heat.toml
 
 # run container
@@ -88,3 +89,5 @@ RUN echo '/usr/local/julia/lib' > /etc/ld.so.conf.d/julia.conf && ldconfig
 # TODO run server as non-root user
 
 ENTRYPOINT ["/usr/local/bin/run_bmi_server"]
+
+# TODO document how to use this Dockerfile together with another Julia BMI model
diff --git a/test/heat-images/c-julia/run_bmi_server.cc b/test/heat-images/c-julia/run_bmi_server.cc
@@ -270,6 +270,7 @@ int main(int argc, char *argv[])
             */
         }
         {
+            // TODO read BmiJulia from env var or cli arguments
             bmi::Bmi* model = new BmiJulia("Heat", "Heat.Model");
             // Calling without grpc works
             // model->Initialize("/usr/local/share/heat.toml");