Update Dockerfile #154
Open
Update Dockerfile #154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For some reason, some of the libraries used by absl_check (part of Abseil, a dependency of gRPC) weren't found when linking grpc4bmi. Locating absl_check and linking against it solved the problem.
mdpiper
commented
Oct 15, 2024
| WORKDIR /opt/grpc4bmi/cpp/build | ||
| RUN cmake .. | ||
| RUN make install | ||
| RUN git clone --branch update-dockerfile --depth 1 https://github.com/csdms/grpc4bmi /opt/grpc4bmi |
There was a problem hiding this comment.
A note: if this PR is approved, the grpc4bmi remote needs to be switched from csdms back to eWaterCycle, and the build branch from update-dockerfile to main.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the Dockerfile used to build the grpc4bmi C++ server.
In this set of changes, I tried to use some of the latest best practices for Dockerfiles. I chose to build on the most recent Ubuntu LTS release image, as well as a recent version of gRPC.
There are two changes I made that may raise questions, both related to the abseil library used by gRPC.
CMakeLists.txt.I hope this is helpful, and I welcome any comments!