Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix deprecated action "sync" #129

Merged
merged 1 commit into from
Mar 8, 2024
Merged

Fix deprecated action "sync" #129

merged 1 commit into from
Mar 8, 2024

Conversation

Varkal
Copy link
Contributor

@Varkal Varkal commented Mar 6, 2024

Hi !

From what i've understand of how your code works, the "sync" action disappeared.

This fix the ability to sync just one entity. I didn't check if there is other mention of it elsewhere in the codebase, this just fix the bug who annoy me :-)

Copy link
Owner

@eXaminator eXaminator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, thanks a lot. Seems I missed the grid view. You change looks good, but I'll give it a quick test tonight before I merge it.

@eXaminator
Copy link
Owner

I have one small change request: Could you please change the commit message a bit? Ideally to something like fix: fix sync of single entries in grid view. I am using semantic release, so this way it will know that this is a bugfix (and create a patch release) and also automatically add the message to the changelog. After that I'm happy to merge this!

@Varkal
Copy link
Contributor Author

Varkal commented Mar 7, 2024

Of course !

@eXaminator eXaminator merged commit 88ec4e6 into eXaminator:main Mar 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants