[feature] gh package snapshots... #5596
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
from CI (hopefully)
adamretter
reviewed
Jan 2, 2025
adamretter
suggested changes
Jan 2, 2025
line-o
reviewed
Jan 2, 2025
|
dizzzz
approved these changes
Jan 3, 2025
adamretter
suggested changes
Jan 3, 2025
| @@ -1228,13 +1239,24 @@ | |||
| <enabled>true</enabled> | |||
| </snapshots> | |||
| </pluginRepository> | |||
| <pluginRepository> | |||
There was a problem hiding this comment.
This is not needed as there are no plugins that we publish.
There was a problem hiding this comment.
@duncdrum was this needed for snapshots of the sub-projects to be published to the registry?
line-o
approved these changes
Jan 4, 2025
| @@ -1228,13 +1239,24 @@ | |||
| <enabled>true</enabled> | |||
| </snapshots> | |||
| </pluginRepository> | |||
| <pluginRepository> | |||
There was a problem hiding this comment.
@duncdrum was this needed for snapshots of the sub-projects to be published to the registry?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
from CI (hopefully)
The previous SNAPSHOT repo hasn't seen any traffic for over a year. This automates release snapshots to GitHub on push events on develop.
We could make the step, run only after tests have passed (as they should always be green on develop anyway) but that would mean that every time the OWASP dependency check times out, we won't publish artefacts. So I decided against it. What do others think?
This will also not publish artefacts from PRs by design, but this could be adjusted.
close #5592