Skip to content

Compatibility with older version of virt-install #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

anesheret
Copy link

* Ubuntu 20.04.6 LTS - compatibility
* Using `cloud-localds` - as described in cloud-init documentation
* `virsh` - auto remove all associated storage volumes

    * Ubuntu 20.04.6 LTS - compatibility
    * Using `cloud-localds` - as described in cloud-init documentation
    * `virsh` - auto remove all associated storage volumes
Copy link

@holmanb holmanb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Using cloud-localds - as described in cloud-init documentation

But why?

cloud-localds is a wrapper around genisoimage, and cloud-utils isn't shipped to as many distros as genisoimage. The only benefit to cloud-localds, as I see it, is that it has a simpler command line invocation, but for a script like this that benefit is lost.

Also, information in the commit message about how virt-install fails and which version the change was made in would be valuable for reviewers and future users of this script.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants