Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow using refs on easyblock components #81

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

chudesno
Copy link

@chudesno chudesno commented Nov 8, 2024

This PR makes it possible to use useRef with child easyblock components.

Consider having 2 easyblock components: MyForm and MyInput. Suppose form component has to focus a child input when the button inside of the form is clicked.

This is commonly achieved through usage of useRef/forwardRef.

const MyForm = ({ MyInput, ...props }: NoCodeComponentProps) => {
  const inputRef = useRef<HTMLInputElement>(null);
  return (
    <form>
      <MyInput.type {...MyInput.props} ref={inputRef}>
        {props.label}
      </MyInput.type>
      <Button onClick={() => inputRef.current?.focus()}>Focus</Button>
    </form>
  );
};

However MyInput.type acrually refers to an internal easyblocks wrapper component ComponentBuilder which does not pass ref down the tree to the actual input component resolved in runtime.

To solve that, this PR wraps ComponentBuilder definition into forwardRef and passes ref down to the actual component implementation.

Copy link

vercel bot commented Nov 8, 2024

Someone is attempting to deploy a commit to the Shopstory Team on Vercel.

A member of the Team first needs to authorize it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant