adopt module_load_environment: GCC
#3556
Conversation
|
@boegelbot please test @ jsc-zen3 |
| @@ -203,6 +203,13 @@ def __init__(self, *args, **kwargs): | |||
| self.log.warning('Setting withnvptx to False, since we are building on a RISC-V system') | |||
| self.cfg['withnvptx'] = False | |||
|
|
|||
| # define list of subdirectories in search paths of module load environment | |||
| self.module_load_environment.PATH = ['bin'] | |||
| self.module_load_environment.LD_LIBRARY_PATH = ['lib', 'lib64'] | |||
There was a problem hiding this comment.
These two lines don't need to be here since framework takes care of this exactly like this
|
@boegel: Request for testing this PR well received on jsczen3l1.int.jsc-zen3.fz-juelich.de PR test command '
Test results coming soon (I hope)... - notification for comment with ID 2636778129 processed Message to humans: this is just bookkeeping information for me, |
| self.module_load_environment.LD_LIBRARY_PATH = ['lib', 'lib64'] | ||
| # GCC can find its own headers and libraries but the .so's need to be in LD_LIBRARY_PATH | ||
| self.module_load_environment.CPATH = [] | ||
| self.module_load_environment.LIBRARY_PATH = ['lib', 'lib64'] if get_cpu_family() == RISCV else [] |
There was a problem hiding this comment.
Not 100% sure, but I think the final installation wouldn't work without this either.
| self.module_load_environment.PATH = ['bin'] | ||
| self.module_load_environment.LD_LIBRARY_PATH = ['lib', 'lib64'] | ||
| # GCC can find its own headers and libraries but the .so's need to be in LD_LIBRARY_PATH | ||
| self.module_load_environment.CPATH = [] |
There was a problem hiding this comment.
Rather than setting CPATH explicitly, this should be changed to using the utility functions being added in:
|
Test report by @boegel Overview of tested easyconfigs (in order)
Build succeeded for 4 out of 4 (4 easyconfigs in total) |
|
Test report by @boegelbot Overview of tested easyconfigs (in order)
Build succeeded for 5 out of 5 (5 easyconfigs in total) |
|
I'll leave this as-is, since it gets rid of using the deprecated We'll need another pass over this after easybuilders/easybuild-framework#4655 got merged since we're hard setting |
Update of GCC easyblock for #3527
Note:
PATHandLD_LIBRARY_PATHare default and could be removed