Skip to content

Commit

Permalink
Mention individual files copied during error artifact persistence
Browse files Browse the repository at this point in the history
When copying logs and artifacts from failed builds, mention the full
target path instead of its parent. This reduces the number of actions
required to access the artifacts (select, paste, and enter).
  • Loading branch information
gkaf89 committed Feb 8, 2025
1 parent d52d744 commit ea723dd
Showing 1 changed file with 4 additions and 3 deletions.
7 changes: 4 additions & 3 deletions easybuild/framework/easyblock.py
Original file line number Diff line number Diff line change
Expand Up @@ -4436,8 +4436,8 @@ def create_persistence_paths(operation_args):

def execute_and_log_persistence_operation(operation, source_paths, target_dir, msg, silent):
for path in source_paths:
if os.path.exists(path):
operation(path, target_dir)
operation(path, target_dir)

print_msg(msg, log=_log, silent=silent)


Expand Down Expand Up @@ -4470,12 +4470,13 @@ def persist_failed_compilation_log_and_artifacts(build_successful, application_l
silent=silent
)
else:
log_file_copies = [os.path.join(log_error_path, os.path.basename(log)) for log in logs]
operation_args.append(
(
copy_file,
logs,
log_error_path,
f"Logs of failed build copied to permanent storage: {log_error_path}"
"Logs of failed build copied to permanent storage: " + ', '.join(log_file_copies)
)
)

Expand Down

0 comments on commit ea723dd

Please sign in to comment.