Small improvements to ModuleLoadEnvironment
#4754
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I just checked #4653 and found a few possible improvements:
self.install_lib_symlink == LibSymlink.LIB64_TO_LIB
might silently fail if it is forgotten. Use a property with auto-init insteaddef __init__(... var_type=ModEnvVarType.PATH_WITH_FILES...)
clearer in what the default is instead of using and checking forNone
?for attr in self.__dict__: yield attr, getattr(self, attr)
can be made simpler and faster by usingyield from self.__dict__.items()
or just returning the latterenviron
can use a dict-comprehension for brevity and speed to avoid repeatedupdate
callsDo those make sense? @lexming @boegel