Skip to content

Introduce 'check_readelf_rpath' easyconfig parameter to optionally skip RPATH checks #4768

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 10 commits into
base: develop
Choose a base branch
from

Conversation

pavelToman
Copy link

@pavelToman pavelToman commented Feb 20, 2025

This commit adds a new easyconfig variable named 'check_readelf_rpath'. When set to False, RPATH checks by readelf are skipped even if the --rpath flag is present. This provides more flexible control over RPATH validation in specialized build scenarios (as git-lfs).

resolves vscentrum/vsc-software-stack#502
resolves easybuilders/easybuild-easyconfigs#17516

This commit adds a new easyconfig variable named 'check_readelf_rpath'. 
When set, RPATH checks are skipped even if the --rpath flag is present.
This provides more flexible control over RPATH validation in specialized build scenarios (as git-lfs).
@pavelToman pavelToman marked this pull request as draft February 20, 2025 10:53
@pavelToman pavelToman marked this pull request as ready for review February 20, 2025 17:56
@boegel boegel added this to the release after 4.9.4 milestone Feb 24, 2025
@boegel
Copy link
Member

boegel commented Feb 24, 2025

@pavelToman Can you look into adding a test for this?

Probably test/framework/toy_build.py is a good place.

You can run a particular test using a command like:

python -m test.framework.toy_build  test_toy_rpath

@boegel boegel changed the title Introduce 'check_readelf_rpath' variable to optionally skip RPATH checks Introduce 'check_readelf_rpath' easyconfig parameter to optionally skip RPATH checks Feb 26, 2025
@boegel boegel modified the milestones: release after 4.9.4, release after 5.0.0 Mar 17, 2025
@laraPPr
Copy link

laraPPr commented Apr 9, 2025

@pavelToman Can you look into resolving the conflict?

@boegel
Copy link
Member

boegel commented Apr 10, 2025

Another use case for this is QuPath-0.5.0-GCCcore-12.3.0-Java-17.eb, which also fails in RPATH sanity check (for no good reason).

For now, people can use eb --disable-rpath to dance around it

@pavelToman
Copy link
Author

Checks are failing on:

easybuild.tools.build_log.EasyBuildError: "Installation of toy-app-0.0.eb failed: 'Sanity check failed: Library libtoy.so not found for /tmp/eb-demet2nb/eb-30flw7j2/eb-hftmdbi_/tmpx81fy1mn/software/toy-app/0.0/bin/toy-app'"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

git-lfs v3.2.0 eb git-lfs-3.2.0.eb --rpath fails on RPATH sanity check
4 participants