use new dlogspline #633
Merged
use new dlogspline #633
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could there be an issue with this warning:
? |
|
Yeah, the package was pushed to CRAN like an hour an a half ago - so the binaries aren't available yet 😅 |
|
Can we merge this? |
|
If tests are passing (they should) - yes! |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #633 +/- ##
==========================================
+ Coverage 52.41% 52.51% +0.09%
==========================================
Files 65 65
Lines 5334 5315 -19
==========================================
- Hits 2796 2791 -5
+ Misses 2538 2524 -14 ☔ View full report in Codecov by Sentry. |
|
"Passing tests on bayestestR" |
|
Bam! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves precision of logBFs in
bayesfactor_parameters.All tests related to those changes pass.