Add more CI #12
Merged
Add more CI #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We return early in a couple of places, after allocating memory.
Some terminals expose the available width inside an environment variable, so we can use it as a fallback if TIOCGWINSZ does not work, or is not supported. If both paths fail, we fall back to standard ANSI terminal sizes.
Static analysis raised potential edge cases.
We need to run more tests in our CI pipeline - a straight up build and test run - a build with ASAN - a build with UBSAN - a build with Clang's static analyser - a coverage report As the last two steps are slightly more expensive, we should run them only if the main build was successful.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.