Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more CI #12

Merged
merged 4 commits into from
Oct 30, 2019
Merged

Add more CI #12

merged 4 commits into from
Oct 30, 2019

Conversation

ebassi
Copy link
Owner

@ebassi ebassi commented Sep 30, 2019

No description provided.

We return early in a couple of places, after allocating memory.
Some terminals expose the available width inside an environment
variable, so we can use it as a fallback if TIOCGWINSZ does not
work, or is not supported.

If both paths fail, we fall back to standard ANSI terminal sizes.
Static analysis raised potential edge cases.
We need to run more tests in our CI pipeline

 - a straight up build and test run
 - a build with ASAN
 - a build with UBSAN
 - a build with Clang's static analyser
 - a coverage report

As the last two steps are slightly more expensive, we should run them
only if the main build was successful.
@ebassi ebassi merged commit b1ae061 into master Oct 30, 2019
@ebassi ebassi deleted the more-ci branch October 30, 2019 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant