Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make region required in Part 3 docs #525

Open
wants to merge 7 commits into
base: release/3.0
Choose a base branch
from

Conversation

nigelmegitt
Copy link
Collaborator

Updates the XSD to match the spec, which requires that if a layout element is present, it must have at least one region child. In Part 3 the layout element itself is optional, but in Part 1 it is required.

Also update the test XML templates to be valid: many of them had invalid empty layout elements.

Fix the Segmenter so that if a layout element has no region children, the layout element itself is removed.

Closes #524.

Updates the XSD to match the spec, which requires that if a `layout` element is present, it must have at least one `region` child. In Part 3 the `layout` element itself is optional, but in Part 1 it is required.

Also update the test XML templates to be valid: many of them had invalid empty `layout` elements.

Fix the Segmenter so that if a `layout` element has no `region` children, the `layout` element itself is removed.

Closes #524.
@coveralls
Copy link

Coverage Status

Coverage increased (+0.003%) to 85.148% when pulling f6fcbb4 on issue-524-require-region-in-layout into 599252f on release/3.0.

Remove pytest-capturelog as it is now built into pytest
WIP - about half way there.

Must now use `parsers.parse()` for inserted variables.
This means some steps cannot be distinguished by their variable names, and need editing.

Empty example values no longer get automatically translated: fix/workaround is to provide fixture definitions for the variable and match strings excluding the variable.

`@given` no longer defines fixtures, but we depend on them being fixtures in a lot of places, so define `target_fixture=` explicitly.
@nigelmegitt nigelmegitt requested a review from spoeschel December 7, 2021 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants