Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add support for regular layouts and HOA output #57

Draft
wants to merge 31 commits into
base: master
Choose a base branch
from
Draft

add support for regular layouts and HOA output #57

wants to merge 31 commits into from

Conversation

tomjnixon
Copy link
Member

@tomjnixon tomjnixon commented Dec 14, 2022 •
edited
Loading

Regular layouts

These currently have to be added to ear/core/data/2051_layouts.yaml -- see this for example.

I don't want to add these to the repository as I don't think there's a standard channel format, but i'd consider adding a CLI option to read them from a file.

HOA output

This should work well for DirectSpeakers, HOA and Objects input, provided extent and diffuse parameters are not used. These are implemented, but I need to look again at the decorrelation filters and extent behavior

HOA output can be enabled by passing something like -s ambix_2 for 2nd order ambix output -- see ear-render --help for details.

Todo:

  • remove quadpy dependency! This was developed against the GPL3 version, but this is no longer easy to install.
  • add channel orders other than ACN? i don't really want to encourage this though
  • check decorrelation filters
    • check overall level
    • check that it's right for different normalisations
    • document and discuss the design
  • add tests for new HOA components
  • build existing components in tests from new singledispatch functions
  • add to changelog

@tomjnixon tomjnixon changed the title add support for egular layouts and HOA output add support for regular layouts and HOA output Dec 15, 2022
@tomjnixon
remove unused import
70c5767
@tomjnixon
support regular layouts with no defined allocentric positions
7f51851
@tomjnixon
remove development config file mechanism
5a2b6d1 
this was more complicated than it needed to be for the current usage, and
makes it difficult to make structures where the set of options is more
dynamic

all the options should be the same; the only API change is the removal
of the actual options structures
@tomjnixon
fix whitespace
a8654d6
@tomjnixon
fix whitespace
2b9733d
@tomjnixon
fix comment
ea7ba36
@tomjnixon
fix ambiguous name warning
84cdea7
@tomjnixon
fix indent
e227ede
@tomjnixon
remove unused imports
8cd8663
@tomjnixon
move noqa labels to correct line
2a68322
@tomjnixon
support regular layouts with no defined allocentric positions
67f761f
@tomjnixon
direct speakers: extract screen edge lock code
f124d5a
@tomjnixon
use multipledispatch for python 3.7 compatibility
8d270f4
@tomjnixon
add num_channels to Layout
7435371 
layout-like objects may not have a use for a list of channels, so this
is easier to generalise
@tomjnixon
use layout.num_channels
6055fef 
just the ones needed; converting all uses would be a lot of pointless
changes
@tomjnixon
direct speakers: extract speaker label handling for re-use
609b25a
@tomjnixon
direct speakers: allow overloading panner for other formats
36cddb9
@tomjnixon
objects: allow overloading renderer for other formats
2382348
@tomjnixon
HOA: allow overloading decoder design for other formats
e983d08
@tomjnixon
add renderer overloads for HOA output
f9795cb
@tomjnixon
document HOA output on command line
452e750
@tomjnixon
fixup: add HOA warnings
12234bb
@tomjnixon
test scenebased
d5d66b0
@tomjnixon
improve sph_harm docs
67435f4
@tomjnixon
test directspeakers hoa
bfc844d
@tomjnixon
test objectbased hoa
95e0202
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@tomjnixon