-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reduce dual pack + channel from error to warn #80
base: master
Are you sure you want to change the base?
Conversation
Hi, thanks for having a look at this. My approach with this kind of thing has been that invalid ADM data should result in errors, and to provide tools to fix files that have common issues. This way, users can still render invalid files, but it needs to be clear that they are invalid and should be fixed before they are used in downstream processes. The question then is whether this is valid or not; i think it's unclear:
For this particular issue the meaning is clear, but these files have other problems, some of which do cause incorrect rendering (e.g. un-labelsd LFE DirectSpeaker channels), and I'd like to fix all these at the same time to avoid people thinking that they work when they actually don't. I've set out the approach I think we should take previously in #39 . Hopefully I can find some time to work on this, but i'm not sure. |
Maybe I get it wrong... This sounds to me related to the well-known issue with any 'Dolby ADM' (which is an 'special flavour' of BS.2076-0), regardless with which 'Dolby-ADM-compatible' tool it's created (DAW or DaVinci Resolve NLE). |
Thanks for this tip, hadn't known about the toolbox @WernerBleisteiner . Are you perchance on a Mac, having the hardest time, granted the C world is not my forté. I created an issue: |
Ah. Sorry @JohnnyMarnell. I'd forgotten that EAT runs not on Mac, although it's is my main tool, too. |
Ah good to know, appreciate that @WernerBleisteiner, and seconded on lay-off sparing hopes. I was canned from Spotify in 2023. I have played with some cross compiling via Docker before, to some success. If I find time, I'll keep you (and EBU community) posted. |
Hello and thanks for the great work here! I tried to render two Atmos BWF's, one created with Dolby Atmos Renderer and another with Fiedler Atmos Composer, both write axml with stream formats referencing both pack + channel formats.
Changing this to a warning instead allows the process to succeed and sounds correct / expected loudness.