Added speculative fix for invalid memory access when app is in background #3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a speculative fix for solving the issue regarding the invalid memory in #2
Theory
When the App is in the background at least 2 events get logged with the completionBlock in
PeachCollectorQueue.m
:this codeblock then gets added to the queue multiple times, same as the number of events.
When the first queue later gets to the first event everything works. However, somewhere in the
flush
orcheckPublishers
call the second event get processed and deleted.When the queue then gets to processing the second event the
addedEvent
object is nil, causing theshouldBeFlushedWhenReceivedInBackgroundState
to crash.Haven't been able to replicate this, therefore its purely speculative but I think it's worth trying to see if this solves our crashes