clean up of QualNameAffectedCommand and QualNameChangeListener

eclipse-4diac · Jan 20, 2025 · abef213 · abef213
1 parent 52ac4ad
commit abef213
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 11 deletions.
diff --git a/...de.model.commands/src/org/eclipse/fordiac/ide/model/commands/QualNameAffectedCommand.java b/...de.model.commands/src/org/eclipse/fordiac/ide/model/commands/QualNameAffectedCommand.java
@@ -32,17 +32,14 @@ public interface QualNameAffectedCommand extends ScopedCommand {
 	 * encapsulate the change to not provide the command to the receiver
 	 */
 	default QualNameChange getQualNameChange(final QualNameChangeState state) {
-		return new QualNameChange(getOldQualName(), getNewQualName(), getChangedElement(), getTypeEntry(getChangedElement()),
-				state);
+		return new QualNameChange(getOldQualName(), getNewQualName(), getChangedElement(),
+				getTypeEntry(getChangedElement()), state);
 	}
 
 	static TypeEntry getTypeEntry(final INamedElement notifier) {
 		final EObject rootContainer = EcoreUtil.getRootContainer(notifier);
 		Assert.isTrue(rootContainer instanceof LibraryElement);
-		if (rootContainer instanceof final LibraryElement element) {
-			return element.getTypeEntry();
-		}
-		return null;
+		return ((LibraryElement) rootContainer).getTypeEntry();
 	}
 
 }
diff --git a/...ide.model.commands/src/org/eclipse/fordiac/ide/model/commands/QualNameChangeListener.java b/...ide.model.commands/src/org/eclipse/fordiac/ide/model/commands/QualNameChangeListener.java
@@ -45,7 +45,7 @@ protected abstract List<AbstractOperation> constructExecutableUndoOperations(fin
 
 	protected void onCommandExecuted(final QualNameChange qualNameChange) {
 		if (isEnabled(qualNameChange.notifier())) {
-			addToPendingList(qualNameChange);
+			addChangeToPendingList(qualNameChange);
 		}
 	}
 
@@ -55,10 +55,6 @@ protected void onCommandUndoExecuted(final QualNameChange qualNameChange) {
 		}
 	}
 
-	private void addToPendingList(final QualNameChange qualNameChange) {
-		addChangeToPendingList(qualNameChange);
-	}
-
 	void onCommandRedoExecuted(final QualNameChange qualNameChange) {
 		addChangeToPendingList(qualNameChange);
 	}