Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added open type in editor on instance viewer screen #846

Closed
wants to merge 19 commits into from
Closed

Added open type in editor on instance viewer screen #846

wants to merge 19 commits into from

Conversation

alliuqemal
Copy link

No description provided.

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 9, 2024 •
edited
Loading

Test Results

   111 files  ±0     111 suites  ±0   47s ⏱️ -2s
29 174 tests ±0  29 174 ✅ ±0  0 💤 ±0  0 ❌ ±0 
29 175 runs  ±0  29 175 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 140820d. ± Comparison against base commit 8b3ce2e.

♻️ This comment has been updated with latest results.

azoitl
azoitl requested changes Dec 10, 2024
View reviewed changes
Copy link
Contributor

@azoitl azoitl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With your changes it feels now that we have the open type in three different places in the pop-up menu. Can you please harmonize to one.

plugins/org.eclipse.fordiac.ide.application/plugin.xml
@@ -1544,19 +1563,25 @@
</command>
<command commandId="org.eclipse.fordiac.ide.application.commands.openType">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is now twice in the pop-up menu

@oberlehner oberlehner self-requested a review December 10, 2024 12:04
oberlehner
oberlehner requested changes Dec 10, 2024
View reviewed changes
Copy link
Contributor

@oberlehner oberlehner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

In this situation, i want to

  1. enable "Open Type in Editor"
  2. It needs to jump to the FBNetwork Editor to Test->Subapp

@alliuqemal alliuqemal force-pushed the feature/type-editor-menu branch from dfef275 to 5df7d18 Compare January 7, 2025 12:26
@alliuqemal alliuqemal force-pushed the feature/type-editor-menu branch from b020a22 to 2bb5dc5 Compare January 15, 2025 13:17
@alliuqemal alliuqemal force-pushed the feature/type-editor-menu branch from 89ac0d4 to f26afca Compare January 22, 2025 13:09
@alliuqemal alliuqemal force-pushed the feature/type-editor-menu branch 2 times, most recently from f1a093d to c77bb57 Compare January 23, 2025 14:21
@alliuqemal alliuqemal force-pushed the feature/type-editor-menu branch from c77bb57 to bd4b15b Compare January 23, 2025 14:26
@alliuqemal alliuqemal closed this Jan 23, 2025
@alliuqemal alliuqemal deleted the feature/type-editor-menu branch January 23, 2025 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oberlehner oberlehner oberlehner requested changes

@azoitl azoitl azoitl requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alliuqemal @azoitl @oberlehner