Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve changing values in variables view #974

Merged
merged 1 commit into from
Jan 21, 2025

Conversation

mx990
Copy link
Member

@mx990 mx990 commented Jan 20, 2025

Improve changing values in variables view:

  • Add shortcut to change variable value
  • Allow changing multiple values at once
  • Show simplified input dialog for single values
  • Show structured edit dialog for structured values
  • Show structured edit dialog for multiple variables

Copy link

github-actions bot commented Jan 20, 2025

Test Results

   111 files  ±0     111 suites  ±0   49s ⏱️ -1s
29 174 tests ±0  29 174 ✅ ±0  0 💤 ±0  0 ❌ ±0 
29 175 runs  ±0  29 175 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 07ceada. ± Comparison against base commit abef213.

♻️ This comment has been updated with latest results.

@mx990 mx990 requested a review from azoitl January 20, 2025 12:46
</extension>
<extension
point="org.eclipse.ui.menus">
<menuContribution
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shouldn't we also have one for single variable selection?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The single variable selection is already handled by an action in the Variables view.

@mx990 mx990 force-pushed the debugMultiChangeValue branch from 888e92e to 54d50c9 Compare January 21, 2025 09:30
@mx990 mx990 requested a review from oberlehner January 21, 2025 09:32
Improve changing values in variables view:
- Add shortcut to change variable value
- Allow changing multiple values at once
- Show simplified input dialog for single values
- Show structured edit dialog for structured values
- Show structured edit dialog for multiple variables
@mx990 mx990 force-pushed the debugMultiChangeValue branch from 54d50c9 to 07ceada Compare January 21, 2025 11:11
@mx990
Copy link
Member Author

mx990 commented Jan 21, 2025

It seems there is again a flaky test in org.eclipse.fordiac.ide.test.library. Hopefully it runs though this time.

@oberlehner oberlehner merged commit a712d0b into eclipse-4diac:develop Jan 21, 2025
4 checks passed
@mx990 mx990 deleted the debugMultiChangeValue branch January 21, 2025 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants