Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide text action bar contributor for text editors in type editor #978

Merged

Conversation

mx990
Copy link
Member

@mx990 mx990 commented Jan 21, 2025

The text editors inside a multi-page type editor need to have a proper text action contributor to properly support switching of actions between pages and also for the new search overlay. This provides a text action bar contributor for text editors inside a type editor.

@mx990 mx990 requested review from azoitl and oberlehner January 21, 2025 09:02
Copy link

github-actions bot commented Jan 21, 2025

Test Results

   111 files  ±0     111 suites  ±0   49s ⏱️ -1s
29 174 tests ±0  29 174 ✅ ±0  0 💤 ±0  0 ❌ ±0 
29 175 runs  ±0  29 175 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 10f46d5. ± Comparison against base commit abef213.

♻️ This comment has been updated with latest results.

The text editors inside a multi-page type editor need to have a proper
text action contributor to properly support switching of actions between
pages and also for the new search overlay. This provides a text action
bar contributor for text editors inside a type editor.
@mx990 mx990 force-pushed the editorMultiPageTextActionContributor branch from ac53339 to 10f46d5 Compare January 21, 2025 11:09
@azoitl azoitl merged commit 4039834 into eclipse-4diac:develop Jan 21, 2025
4 checks passed
@mx990 mx990 deleted the editorMultiPageTextActionContributor branch January 21, 2025 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants