Sort Project Configurators according to their runsBefore/runsAfter attributes (#1032) #1215
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tributes (eclipse-buildship#1032) When adding a ProjectConfigurator with the extension "org.eclipse.buildship.core.projectconfigurators", the "runsBefore" and "runsAfter" attributes are not considered. No matter the values set on these attributes, the new ProjectConfigurator is always executed the default ones. This change makes sure that the ProjectConfigurator objects returned by the method org.eclipse.buildship.core.internal.extension.InternalProjectConfigurator.from(List<ProjectConfiguratorContribution>) are always sorted according the these attributes. The related tests have been adapted to test the behavior of the org.eclipse.buildship.core.internal.extension.InternalProjectConfigurator.from(List<ProjectConfiguratorContribution>) method.
|
@thomasdelhomenie thank you for the contribution! I'd like to approve and merge your changes, however, you need to sign the Eclipse Contributor Agreement before: https://www.eclipse.org/projects/handbook/#resources-github |
|
@donat done, I signed the ECA. |
|
@thomasdelhomenie Thank you for the contribution! |
|
@donat my pleasure :) thanks! Any plan for a new release? |
|
No hard deadlines yet, but I want to have a release soon-ish. One thing I really want in the next release is this PR (WIP). In the meanwhile, snapshot releases are produced fairly regularly. I'll make sure there's one with your changes. |
|
ok great, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1032
Context
When adding a ProjectConfigurator with the extension "org.eclipse.buildship.core.projectconfigurators", the "runsBefore" and "runsAfter" attributes are not considered. No matter the values set on these attributes, the new ProjectConfigurator is always executed the default ones.
This change makes sure that the ProjectConfigurator objects returned by the method org.eclipse.buildship.core.internal.extension.InternalProjectConfigurator.from(List) are always sorted according the these attributes.
The related tests have been adapted to test the behavior of the org.eclipse.buildship.core.internal.extension.InternalProjectConfigurator.from(List) method.
#1032