CI publish: Add release workflow/job, publish-latest job #270
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcdumais-work
force-pushed
the
ci-publish
branch
2 times, most recently
from
405996d to
74ea325
Compare
marcdumais-work
commented
Feb 14, 2024
marcdumais-work
commented
Feb 14, 2024
marcdumais-work
commented
Feb 14, 2024
|
|
marcdumais-work
force-pushed
the
ci-publish
branch
9 times, most recently
from
8232bfd to
74ea325
Compare
marcdumais-work
force-pushed
the
ci-publish
branch
from
74ea325 to
c7e08e5
Compare
Signed-off-by: Marc Dumais <[email protected]>
The new release workflow uses action "pipe-cd/actions-gh-release". This action uses file RELEASE in the root. When that file is modified in a PR, and contains a new release tag, it will trigger a release upon the PR being merged. The action will create a git tag in the repo and the corresponding GitHub release, containing auto-generated release notes, that can be later edited by a committer. The new release will in turn trigger the new "publish-latest" job (ci-cd workflow), which will publish the new version of the package to npm. Signed-off-by: Marc Dumais <[email protected]>
marcdumais-work
force-pushed
the
ci-publish
branch
from
c7e08e5 to
41d838a
Compare
|
I have tested |
marcdumais-work
changed the title
bhufmann
approved these changes
Mar 1, 2024
bhufmann
requested changes
Mar 1, 2024
timeline-chart/package.json
Outdated
| "ts-jest": "^29.0.0" | ||
| }, | ||
| "homepage": "https://github.com/theia-ide/timeline-chart", |
There was a problem hiding this comment.
this webpage is not correct. It should be https://github.com/eclipse-cdt-cloud/timeline-chart, right?
There was a problem hiding this comment.
oops - good catch
marcdumais-work
force-pushed
the
ci-publish
branch
from
41d838a to
6118b8b
Compare
add release instructions in root README enhance the library's package.json add README for npm package massaged,Fixed linter warnings in documentation.md, README Signed-off-by: Marc Dumais <[email protected]>
marcdumais-work
force-pushed
the
ci-publish
branch
from
6118b8b to
1f6625a
Compare
bhufmann
approved these changes
Mar 1, 2024
|
Thanks for the review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new release workflow uses action "pipe-cd/actions-gh-release". This action uses file RELEASE in the root. When that file is modified in a PR, and contains a new release tag, it will trigger a release upon the PR being merged. The action will create a git tag in the repo and the corresponding GitHub release, containing auto-generated release notes, that can be later edited by a committer.
The new release will in turn trigger the new "publish-latest" job (ci-cd workflow), which will publish the new version of the package to npm.
Also made misc improvements, e.g. in the package.json, README, ...
Note: it's expected that the "GitHub release" job will fail for now.
To test locally using e.g.
verdaccio:Look at the release procedure added in the root (developer's) README, section "Release/publish". To test using a local registry, it's required to manually create the release tag (GitHub action
pipe-cd/actions-gh-releasedoes that in the workflow). I purposefully preventedlernacreating that tag [1] when runningyarn version:<release type>to avoid creating a conflicting local tag on a commit that will possibly have a different SHA vs what gets merged, when creating the release PR.[1] by telling lerna to use a bogus command to create the tag:
--git-tag-command /usr/bin/true