Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add schema to ConfigurationSourceType #103

Merged
merged 1 commit into from
Oct 15, 2024

Conversation

bhufmann
Copy link
Collaborator

API.yaml updates to add schema field to ConfigurationSourceType data structure to support json-schemas.

Generated with Trace Compass server swagger update which is part of:
eclipse-tracecompass-incubator/org.eclipse.tracecompass.incubator#66

Signed-off-by: Bernd Hufmann [email protected]

bhufmann added a commit to bhufmann/tsp-python-client that referenced this pull request Aug 30, 2024
bhufmann added a commit to bhufmann/tsp-typescript-client that referenced this pull request Aug 30, 2024
bhufmann added a commit to bhufmann/org.eclipse.tracecompass.incubator that referenced this pull request Aug 30, 2024
See eclipse-cdt-cloud/trace-server-protocol#103

Also, add test for TmfConfigurationSourceType with schema as string.

[Added] Serialize TmfConfigurationSourceType schema as string

Signed-off-by: Bernd Hufmann <[email protected]>
bhufmann added a commit to bhufmann/org.eclipse.tracecompass.incubator that referenced this pull request Aug 30, 2024
See eclipse-cdt-cloud/trace-server-protocol#103

Also, add test for TmfConfigurationSourceType with schema as string.

[Added] Serialize TmfConfigurationSourceType schema as string

Signed-off-by: Bernd Hufmann <[email protected]>
@bhufmann
Copy link
Collaborator Author

bhufmann commented Sep 3, 2024

FYI @abhinava-ericsson

bhufmann added a commit to bhufmann/tsp-typescript-client that referenced this pull request Sep 6, 2024
bhufmann added a commit to bhufmann/tsp-typescript-client that referenced this pull request Sep 6, 2024
The json-schema is stored as a json object.

See eclipse-cdt-cloud/trace-server-protocol#103

Signed-off-by: Bernd Hufmann <[email protected]>
bhufmann added a commit to bhufmann/org.eclipse.tracecompass.incubator that referenced this pull request Sep 6, 2024
See eclipse-cdt-cloud/trace-server-protocol#103

Also, add test for TmfConfigurationSourceType with schema json object.

[Added] Serialize TmfConfigurationSourceType schema as json object

Signed-off-by: Bernd Hufmann <[email protected]>
bhufmann added a commit to bhufmann/org.eclipse.tracecompass.incubator that referenced this pull request Sep 9, 2024
See eclipse-cdt-cloud/trace-server-protocol#103

Also, add test for TmfConfigurationSourceType with schema json object.

[Added] Serialize TmfConfigurationSourceType schema as json object

Signed-off-by: Bernd Hufmann <[email protected]>
bhufmann added a commit to bhufmann/tsp-python-client that referenced this pull request Sep 16, 2024
bhufmann added a commit to bhufmann/org.eclipse.tracecompass.incubator that referenced this pull request Sep 18, 2024
See eclipse-cdt-cloud/trace-server-protocol#103

Also, add test for TmfConfigurationSourceType with schema json object.

[Added] Serialize TmfConfigurationSourceType schema as json object

Signed-off-by: Bernd Hufmann <[email protected]>
@bhufmann bhufmann requested a review from PatrickTasse October 11, 2024 18:20
type: object
description: A JSON object that describes a schema for parameters that the front-end
needs to provide with corresponding values. Use this for complex parameter
descriptions instead of parameterDescriptors. Omit if not used.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please mention that the object should adhere to the JSON Schema specification.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

API.yaml Outdated
type: object
description: A JSON object that describes a schema for parameters that the front-end
needs to provide with corresponding values. Use this for complex parameter
descriptions instead of parameterDescriptors. Omit if not used.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please mention that the object should adhere to the JSON Schema specification.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@bhufmann bhufmann requested a review from PatrickTasse October 15, 2024 14:06
bhufmann added a commit to bhufmann/org.eclipse.tracecompass.incubator that referenced this pull request Oct 15, 2024
See eclipse-cdt-cloud/trace-server-protocol#103

Also, add test for TmfConfigurationSourceType with schema json object.

[Added] Serialize TmfConfigurationSourceType schema as json object

Signed-off-by: Bernd Hufmann <[email protected]>
@bhufmann bhufmann merged commit 4fa4cb8 into eclipse-cdt-cloud:master Oct 15, 2024
1 check passed
@bhufmann bhufmann deleted the json-schema branch October 15, 2024 15:38
bhufmann added a commit to eclipse-tracecompass-incubator/org.eclipse.tracecompass.incubator that referenced this pull request Oct 15, 2024
See eclipse-cdt-cloud/trace-server-protocol#103

Also, add test for TmfConfigurationSourceType with schema json object.

[Added] Serialize TmfConfigurationSourceType schema as json object

Signed-off-by: Bernd Hufmann <[email protected]>
bhufmann added a commit to bhufmann/org.eclipse.tracecompass.incubator that referenced this pull request Oct 16, 2024
See eclipse-cdt-cloud/trace-server-protocol#103

Also, add test for TmfConfigurationSourceType with schema json object.

[Added] Serialize TmfConfigurationSourceType schema as json object

Signed-off-by: Bernd Hufmann <[email protected]>
bhufmann added a commit to bhufmann/org.eclipse.tracecompass.incubator that referenced this pull request Oct 16, 2024
See eclipse-cdt-cloud/trace-server-protocol#103

Also, add test for TmfConfigurationSourceType with schema json object.

[Added] Serialize TmfConfigurationSourceType schema as json object

Signed-off-by: Bernd Hufmann <[email protected]>
bhufmann added a commit to eclipse-cdt-cloud/tsp-typescript-client that referenced this pull request Oct 17, 2024
The json-schema is stored as a json object.

See eclipse-cdt-cloud/trace-server-protocol#103

Signed-off-by: Bernd Hufmann <[email protected]>
bhufmann added a commit to eclipse-cdt-cloud/tsp-python-client that referenced this pull request Oct 17, 2024
bhufmann added a commit to eclipse-tracecompass-incubator/org.eclipse.tracecompass.incubator that referenced this pull request Oct 25, 2024
See eclipse-cdt-cloud/trace-server-protocol#103

Also, add test for TmfConfigurationSourceType with schema json object.

[Added] Serialize TmfConfigurationSourceType schema as json object

Signed-off-by: Bernd Hufmann <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants