Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix React warnings & use after dispose errors #125

Conversation

colin-grant-work
Copy link

@colin-grant-work colin-grant-work commented Apr 10, 2024

What it does

This PR fixes a number of React errors related to keys and element hierarchy that appeared in the dev console when a hover was shown.

In addition, when webview was closed, an error would be logged related to an attempt by vscode-messenger to access a property on the now-disposed-of view. That has been fixed.

How to test

  1. Open up the dev tools.
  2. Open a memory view and show a hover.
  3. No React errors should appear in the dev tools console.
  4. Close the webview.
  5. No errors related to the webview being disposed should appear. Sometimes errors with the text Invalid debug adapter appear, but those appear to be internal to VSCode.

Review checklist

Reminder for reviewers

@gbodeen
Copy link
Contributor

gbodeen commented Apr 11, 2024

Confirmed that I observed no React or other webview errors in dev tools running through the test steps. The code changes make sense for that.

@colin-grant-work colin-grant-work merged commit e469d74 into eclipse-cdt-cloud:main Apr 17, 2024
5 checks passed
@colin-grant-work colin-grant-work deleted the bugfix/react-warnings branch April 17, 2024 21:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants