Update Main Tab for Core Build local launch configurations.

[ewaterlander]

A new Main Tab was created for Core Build local projects based on the Main Tab used for the classic Managed Build projects. It adds these features:

• Option to select a different binary.
• Option to control launch pre-builds.

The default value for the binary is empty string. With empty string the behaviour for binary selection stays the same as it was.

The project name is fixed and cannot be changed. A Core Build launch configuration is created with the project and tied to it.

This change relates to #758. It affects all Core Build projects, including CMake projects.

[ewaterlander]

A picture of the new main tab:

[ewaterlander]

Hi @jonahgraham and @betamaxbandit , would you like to review this PR?

[betamaxbandit]

Hi @ewaterlander ,
thanks for creating the change.

TBH, I'm not sure about this. Everything I've done recently in this area has gone away from having the main tab in the launch configuration delegate. However, I can see how it might be useful if you have projects that contain multiple binaries.

For projects that build a single binary, can you say what the usecase for this is please? After all, if there is only a single binary then it can be selected automatically.

Can you explain what you mean by "Option to control launch pre-builds.".

Cheers John

[ewaterlander]

For projects that build a single binary, can you say what the usecase for this is please?

In our case a binary is built that doesn't run on the local system. The launch starts a local simulator. The simulator will load the binary and run it. So we put the path to simulator in the "C/C++ application" text field, and based on arguments in the Arguments tab the simulator knows what to load.

For plain single binary local programs you just leave the "C/C++ application" text field empty and it will be selected automatically.
And indeed it is helpful for multiple binaries, because currently the automatic selection will pick the first one found.

Can you explain what you mean by "Option to control launch pre-builds.".

You can disable the automatic build before launching, and only trigger a build by manually pushing the build button. This can save you time if you want to do multiple runs and you are only changing input data.

The classic local C/C++ launch configuration also has these features. I think it is good to keep these.

[ewaterlander]

Update: Instead of adding a new class CoreBuildMainTab2 I updated old class CoreBuildMainTab.

[betamaxbandit]

Hi @ewaterlander ,
thanks for the extra details.
For your use case I guess this makes sense.
I'll review the code, hopefully early next week. I need to check how/if this impacts the changes I've made in my client code.
Cheers John

[betamaxbandit]

Look good apart from my concern with CoreBuildMainTab

[ewaterlander]

Hi @betamaxbandit ,
I added a new commit.

[betamaxbandit]

LGTM

[ewaterlander]

LGTM

Hi @betamaxbandit , thanks for the review!
Hi @jonahgraham , would you like to merge it?

[jonahgraham]

Thanks @ewaterlander for the improvement. I have added the noteworthy tag because we should highlight this change. It may be best to add an entry to the N&N document for CDT 12 in the API section: https://github.com/eclipse-cdt/cdt/blob/main/NewAndNoteworthy/CDT-12.0.md#api-changes-current-and-planned

[jonahgraham]

Thanks @betamaxbandit for the review.

[ewaterlander]

I have added the noteworthy tag because we should highlight this change. It may be best to add an entry to the N&N document for CDT 12 in the API section: https://github.com/eclipse-cdt/cdt/blob/main/NewAndNoteworthy/CDT-12.0.md#api-changes-current-and-planned

Hi @jonahgraham and @betamaxbandit ,
I'm working on one other PR that I will upload soon, that will add the Debugger, Source, and Common tabs to the Core Build launch config. When that is done I think the local Core Build launch configuration is finally mature. It will make CMake (and Makefile) local projects usable out of the box.
After that I will add an entry to N&N and also contribute to documentation for Core Build projects.