This repository has been archived by the owner on Aug 16, 2024. It is now read-only.
Update angular stack to use non-alpine image #45
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Angel Misevski <[email protected]>
amisevsk
requested review from
l0rd,
rhopp,
skabashnyuk and
vparfonov
as code owners
|
@l0rd I've created the quay repo for this new image; WDYT about deleting the non-functional https://quay.io/repository/eclipse/che-nodejs10-alpine? |
ibuziuk
approved these changes
Jul 24, 2019
l0rd
approved these changes
Jul 24, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Add new patched image (
che-nodejs10-community) to replacenode:10.16-alpinefor the angular devfile (see discussion #38 (comment)). I've tested the devfile on our dev-cluster deployment and there seem to be no issues (exceptyarn installfailing once)Testing:
Use this devfile
What issues does this PR fix or reference?
Che 7.0.0 blocker: eclipse-che/che#13454