Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the redundant token.yaml empty file #768

Merged
merged 1 commit into from
Feb 25, 2025
Merged

Conversation

vinokurig
Copy link
Contributor

@vinokurig vinokurig commented Feb 25, 2025

What does this PR do?

Remove the empty token.yaml file. A leftover has been committed.

Screenshot/screencast of this PR

What issues does this PR fix or reference?

How to test this PR?

PR Checklist

As the author of this Pull Request I made sure that:

Release Notes

Reviewers

Reviewers, please comment how you tested the PR when approving it.

@vinokurig vinokurig changed the title Remove the redundant token.yaml file Remove the redundant token.yaml empty file Feb 25, 2025
Copy link

openshift-ci bot commented Feb 25, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ibuziuk, tolusha, vinokurig

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ibuziuk
Copy link
Member

ibuziuk commented Feb 25, 2025

@artaleks9 hello, could you please take a look at the failing tests?

@vinokurig
Copy link
Contributor Author

/retest

Copy link

openshift-ci bot commented Feb 25, 2025

@vinokurig: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/v14-gitlab-with-oauth-setup-flow 1cc13be link true /test v14-gitlab-with-oauth-setup-flow

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@artaleks9
Copy link
Contributor

artaleks9 commented Feb 25, 2025

@ibuziuk hello,
the gitlab-with-oauth-setup-flow is fail due to changes with a locator in the editor, the functionality works properly.
Need to fix up the test.

@vinokurig vinokurig merged commit ec603e1 into main Feb 25, 2025
27 of 28 checks passed
@vinokurig vinokurig deleted the remove-token.yaml branch February 25, 2025 15:37
@devspacesbuild
Copy link

Build 3.20 :: server_3.x/384: Console, Changes, Git Data

@devspacesbuild
Copy link

@devspacesbuild
Copy link

@devspacesbuild
Copy link

@devspacesbuild
Copy link

@devspacesbuild
Copy link

Build 3.20 :: server_3.x/384: SUCCESS

Upstream sync done; /DS_CI/sync-to-downstream_3.x/8836 triggered

@devspacesbuild
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants