-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Throw an error if Devfile from unsupported ssh repository is not reso… #770
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: vinokurig The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
dc4c2e9
to
ca140d4
Compare
…lved (#763) Throw an error if Devfile from unsupported ssh repository is not resolved instead of returning an empty factory dto without devfile. The ApiException will be handled by dashboard and default devfile will be used: https://github.com/eclipse-che/che-dashboard/blob/05bf4383a45cb367924c788763beb5c7689a7c79/packages/dashboard-frontend/src/components/WorkspaceProgress/CreatingSteps/Fetch/Devfile/index.tsx#L215
ca140d4
to
732effa
Compare
Build 3.19 :: server_3.19/3: Console, Changes, Git Data |
Build 3.19 :: sync-to-downstream_3.19/102: Console, Changes, Git Data |
Build 3.19 :: push-latest-container-to-quay_3.19/46: Console, Changes, Git Data |
Build 3.19 :: get-sources-rhpkg-container-build_3.19/109: server : 3.19 :: Build 66815311 : quay.io/devspaces/server-rhel9:3.19-7 |
Build 3.19 :: update-digests_3.19/144: Console, Changes, Git Data |
Build 3.19 :: server_3.19/3: Upstream sync done; /DS_CI/sync-to-downstream_3.19/102 triggered |
Build 3.19 :: operator-bundle_3.19/65: Console, Changes, Git Data |
Build 3.19 :: sync-to-downstream_3.19/103: Console, Changes, Git Data |
Build 3.19 :: push-latest-container-to-quay_3.19/47: Console, Changes, Git Data |
Build 3.19 :: sync-to-downstream_3.19/103: Build container: devspaces-operator-bundle synced; /DS_CI/get-sources-rhpkg-container-build_3.19/110 triggered; /job/DS_CI/job/dsc_3.19 triggered; |
Build 3.19 :: operator-bundle_3.19/65: Upstream sync done; /DS_CI/sync-to-downstream_3.19/103 triggered |
Build 3.19 :: copyIIBsToQuay/2931: Console, Changes, Git Data |
Build 3.19 :: dsc_3.19/18: Console, Changes, Git Data |
Build 3.19 :: update-digests_3.19/144: Detected new images: rebuild operator-bundle |
Build 3.19 :: dsc_3.19/18: 3.19.0-CI |
Build 3.19 :: copyIIBsToQuay/2932: Console, Changes, Git Data |
…lved (#763)
Throw an error if Devfile from unsupported ssh repository is not resolved instead of returning an empty factory dto without devfile. The ApiException will be handled by dashboard and default devfile will be used: https://github.com/eclipse-che/che-dashboard/blob/05bf4383a45cb367924c788763beb5c7689a7c79/packages/dashboard-frontend/src/components/WorkspaceProgress/CreatingSteps/Fetch/Devfile/index.tsx#L215
What does this PR do?
cherry-pick from #763
Screenshot/screencast of this PR
What issues does this PR fix or reference?
How to test this PR?
PR Checklist
As the author of this Pull Request I made sure that:
What issues does this PR fix or reference
andHow to test this PR
completedRelease Notes
Reviewers
Reviewers, please comment how you tested the PR when approving it.