Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Throw an error if Devfile from unsupported ssh repository is not reso… #770

Merged
merged 1 commit into from
Feb 26, 2025

Conversation

vinokurig
Copy link
Contributor

…lved (#763)

Throw an error if Devfile from unsupported ssh repository is not resolved instead of returning an empty factory dto without devfile. The ApiException will be handled by dashboard and default devfile will be used: https://github.com/eclipse-che/che-dashboard/blob/05bf4383a45cb367924c788763beb5c7689a7c79/packages/dashboard-frontend/src/components/WorkspaceProgress/CreatingSteps/Fetch/Devfile/index.tsx#L215

What does this PR do?

cherry-pick from #763

Screenshot/screencast of this PR

What issues does this PR fix or reference?

How to test this PR?

PR Checklist

As the author of this Pull Request I made sure that:

Release Notes

Reviewers

Reviewers, please comment how you tested the PR when approving it.

Copy link

openshift-ci bot commented Feb 26, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: vinokurig

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

…lved (#763)

Throw an error if Devfile from unsupported ssh repository is not resolved instead of returning an empty factory dto without devfile. The ApiException will be handled by dashboard and default devfile will be used: https://github.com/eclipse-che/che-dashboard/blob/05bf4383a45cb367924c788763beb5c7689a7c79/packages/dashboard-frontend/src/components/WorkspaceProgress/CreatingSteps/Fetch/Devfile/index.tsx#L215
@vinokurig vinokurig merged commit 44625fb into 7.98.x Feb 26, 2025
6 checks passed
@vinokurig vinokurig deleted the che-23364_7.98.x branch February 26, 2025 12:30
@devspacesbuild
Copy link

Build 3.19 :: server_3.19/3: Console, Changes, Git Data

@devspacesbuild
Copy link

@devspacesbuild
Copy link

@devspacesbuild
Copy link

@devspacesbuild
Copy link

@devspacesbuild
Copy link

@devspacesbuild
Copy link

Build 3.19 :: server_3.19/3: SUCCESS

Upstream sync done; /DS_CI/sync-to-downstream_3.19/102 triggered

@devspacesbuild
Copy link

@devspacesbuild
Copy link

@devspacesbuild
Copy link

@devspacesbuild
Copy link

@devspacesbuild
Copy link

Build 3.19 :: sync-to-downstream_3.19/103: SUCCESS

Build container: devspaces-operator-bundle synced; /DS_CI/get-sources-rhpkg-container-build_3.19/110 triggered; /job/DS_CI/job/dsc_3.19 triggered;

@devspacesbuild
Copy link

Build 3.19 :: operator-bundle_3.19/65: SUCCESS

Upstream sync done; /DS_CI/sync-to-downstream_3.19/103 triggered

@devspacesbuild
Copy link

Build 3.19 :: copyIIBsToQuay/2931: Console, Changes, Git Data

@devspacesbuild
Copy link

Build 3.19 :: dsc_3.19/18: Console, Changes, Git Data

@devspacesbuild
Copy link

Build 3.19 :: update-digests_3.19/144: SUCCESS

Detected new images: rebuild operator-bundle
* server; /DS_CI/operator-bundle_3.19/65 triggered

@devspacesbuild
Copy link

Build 3.19 :: dsc_3.19/18: SUCCESS

3.19.0-CI

@devspacesbuild
Copy link

@devspacesbuild
Copy link

Build 3.19 :: copyIIBsToQuay/2932: Console, Changes, Git Data

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants