Fix #34, #36, #37 #35
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laeubi
suggested changes
Sep 29, 2019
...org/eclipse/chemclipse/chromatogram/msd/peak/detector/settings/IPeakDetectorSettingsMSD.java
Show resolved
Hide resolved
...hromatogram/xxd/peak/detector/supplier/firstderivative/core/FirstDerivativePeakDetector.java
Outdated
Show resolved
Hide resolved
...chemclipse/chromatogram/xxd/peak/detector/supplier/firstderivative/core/PeakDetectorMSD.java
Outdated
Show resolved
Hide resolved
...xxd/peak/detector/supplier/firstderivative/settings/FirstDerivativePeakDetectorSettings.java
Outdated
Show resolved
Hide resolved
...hromatogram/xxd/peak/detector/supplier/firstderivative/settings/PeakDetectorSettingsMSD.java
Outdated
Show resolved
Hide resolved
...src/org/eclipse/chemclipse/chromatogram/msd/peak/detector/settings/PeakDetectorSettings.java
Show resolved
Hide resolved
laeubi
reviewed
Sep 29, 2019
...emclipse.support/src/org/eclipse/chemclipse/support/settings/parser/SettingsClassParser.java
Outdated
Show resolved
Hide resolved
Improve readability by reducing repetitive casts.
👍 |
commit bfaf0d3 Author: Christoph Läubrich <[email protected]> Date: Mon Sep 30 10:19:05 2019 +0200 Fix #42 commit a6a2a59 Author: Christoph Läubrich <[email protected]> Date: Sun Sep 29 19:19:43 2019 +0200 #39 add option to use a preference page instead of a button commit f92601d Author: Christoph Läubrich <[email protected]> Date: Sun Sep 29 18:13:05 2019 +0200 Fix #36 commit 97ac273 Author: Christoph Läubrich <[email protected]> Date: Sun Sep 29 14:49:03 2019 +0200 Fix #39 commit 8f3aa74 Author: Christoph Läubrich <[email protected]> Date: Fri Sep 27 15:14:28 2019 +0200 Fix #33 commit 5b0845d Author: Christoph Läubrich <[email protected]> Date: Fri Sep 27 15:00:11 2019 +0200 Fix #32 commit 7e18420 Author: Christoph Läubrich <[email protected]> Date: Fri Sep 27 08:31:32 2019 +0200 Fix #31 commit 8a26934 Author: Christoph Läubrich <[email protected]> Date: Fri Sep 27 07:51:44 2019 +0200 Refactoring to support #31 commit b8aad6a Author: Christoph Läubrich <[email protected]> Date: Thu Sep 26 19:40:47 2019 +0200 Refactoring to support #31
laeubi
reviewed
Oct 1, 2019
...chemclipse/chromatogram/xxd/peak/detector/supplier/firstderivative/core/PeakDetectorMSD.java
Outdated
Show resolved
Hide resolved
Pass filter ions directly instead of passing #getIonFilter parameters.
Pass filter ions directly instead of passing #getIonFilter parameters.
laeubi
approved these changes
Oct 4, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.