Skip to content

Commit

Permalink
Add TOPIC_DATA to ddsi_default_qos_topic
Browse files Browse the repository at this point in the history
No externally visible effect for applications, but not setting is wrong and affects the
C++ QoS provider implementation because it directly looks at the default QoS objects.

Signed-off-by: Erik Boasson <[email protected]>
  • Loading branch information
eboasson committed Apr 10, 2024
1 parent 826a070 commit 6498bf9
Showing 1 changed file with 3 additions and 1 deletion.
4 changes: 3 additions & 1 deletion src/core/ddsi/src/ddsi_plist.c
Original file line number Diff line number Diff line change
Expand Up @@ -3662,7 +3662,7 @@ const dds_qos_t ddsi_default_qos_writer = {
};

const dds_qos_t ddsi_default_qos_topic = {
.present = DDSI_QP_PRESENTATION | DDSI_QP_DURABILITY | DDSI_QP_DEADLINE | DDSI_QP_LATENCY_BUDGET | DDSI_QP_LIVELINESS | DDSI_QP_DESTINATION_ORDER | DDSI_QP_HISTORY | DDSI_QP_RESOURCE_LIMITS | DDSI_QP_TRANSPORT_PRIORITY | DDSI_QP_OWNERSHIP | DDSI_QP_CYCLONE_IGNORELOCAL | DDSI_QP_DURABILITY_SERVICE | DDSI_QP_RELIABILITY | DDSI_QP_LIFESPAN | DDSI_QP_DATA_REPRESENTATION,
.present = DDSI_QP_PRESENTATION | DDSI_QP_DURABILITY | DDSI_QP_DEADLINE | DDSI_QP_LATENCY_BUDGET | DDSI_QP_LIVELINESS | DDSI_QP_DESTINATION_ORDER | DDSI_QP_HISTORY | DDSI_QP_RESOURCE_LIMITS | DDSI_QP_TOPIC_DATA | DDSI_QP_TRANSPORT_PRIORITY | DDSI_QP_OWNERSHIP | DDSI_QP_CYCLONE_IGNORELOCAL | DDSI_QP_DURABILITY_SERVICE | DDSI_QP_RELIABILITY | DDSI_QP_LIFESPAN | DDSI_QP_DATA_REPRESENTATION,
.aliased = DDSI_QP_DATA_REPRESENTATION,
.presentation.access_scope = DDS_PRESENTATION_INSTANCE,
.presentation.coherent_access = 0,
Expand All @@ -3678,6 +3678,8 @@ const dds_qos_t ddsi_default_qos_topic = {
.resource_limits.max_samples = DDS_LENGTH_UNLIMITED,
.resource_limits.max_instances = DDS_LENGTH_UNLIMITED,
.resource_limits.max_samples_per_instance = DDS_LENGTH_UNLIMITED,
.topic_data.length = 0,
.topic_data.value = NULL,
.transport_priority.value = 0,
.ownership.kind = DDS_OWNERSHIP_SHARED,
.ignorelocal.value = DDS_IGNORELOCAL_NONE,
Expand Down

0 comments on commit 6498bf9

Please sign in to comment.