Speed up attribute handling with fancy quotes #1838
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This
if (n == 0xe2 && (peek_chars (st, "\xe2\x80\x9c", 0) || peek_chars (st, "\xe2\x80\x98", 0))) {
/* allow fancy unicode quotes (U+201c .. U+201d and U+2018 ... U+2019) in
UTF-8 representation because email clients like to rewrite plain ones,
and this has caused people trouble several times already */
(void) next_char (st); (void) next_char (st);
const unsigned char c = (unsigned char) next_char (st);
const unsigned char endm[4] = { 0xe2, 0x80, (unsigned char) (c + 1), 0 };
tok = next_token_string (st, payload, (const char *) endm);
}
nice little hack caused so many calls to strlen en memcmp that it timed
out on OSS-Fuzz. It doesn't seem like an issue for actual
configurations and it does terminate in a few seconds on a normal
machine, but OSS-Fuzz also matters. Fortunately, this case can be fixed
rather easily.
Signed-off-by: Erik Boasson <[email protected]>
dpotman
approved these changes
Sep 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This
nice little hack caused so many calls to strlen en memcmp that it timed out on OSS-Fuzz. It doesn't seem like an issue for actual configurations and it does terminate in a few seconds on a normal machine, but OSS-Fuzz also matters. Fortunately, this case can be fixed rather easily.