Check for required serdata ops before enabling PSMX on an endpoint #1859
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eboasson
approved these changes
Oct 23, 2023
There was a problem hiding this comment.
Thank you @gmartin82 for eliminating that nice little gotcha.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds an additional check to dds_ensure_valid_psmx_instances() which validates that the required serdata operations are present for the sertype. For a writer, it checks for the from_loaned_sample() operation; for a reader, it checks for the from_psmx() operation. If the required operation is not present no PSMX instances will be added to the supported_psmx list.
Without this (or a similar) check, Cyclone may call these operations on a custom sertype implementation that doesn't provide implementations potentially resulting in a segmentation fault. As an example of this, the Zenoh DDS Bridge uses such a custom sertype which is used when type information isn't available.