-
Notifications
You must be signed in to change notification settings - Fork 364
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drop support for OpenSSL pre-1.1.1 #1951
Drop support for OpenSSL pre-1.1.1 #1951
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! In the readme there is a reference to OpenSSL 1.1, that line also needs an update:
Line 117 in 2246c00
* Optionally [OpenSSL](https://www.openssl.org/), preferably version 1.1; |
And here:
cyclonedds/docs/dev/dds_security_effort.md
Line 140 in 2246c00
However, it expects (or at least it's preferred to have) version 1.1 or newer, |
OpenSSL versions older than 1.1.1 have all been dead for over 4 years. I don't see why an Cyclone would have to continue supporting the bad practice of not updating EOL'd security sensitive libraries full of known vulnerabilities. Of course nobody should be using OpenSSL 1.1.1 anymore (it has been EOL'd about half a year ago), but I know there are still plenty of systems in the field that rely on it and even the CI on Azure gets the latest Linux images with it pre-installed. Signed-off-by: Erik Boasson <[email protected]>
7ca9343
to
bee45b1
Compare
Done. I also had to solve some conflicts because of merging #1826 and force-pushing it seemed the most sensible solution. |
Thanks for your attention! I tried to compile with boringssl with this patch, the compile errors disappeared, but there's a linker error:
I thinks it's because boringssl removed some of openssl's api. I have no understanding of Openssl so I don't know if this if a big or small problem... |
Thanks for trying it! The easiest way to work around this would be to just not include the TCP / TCP+TLS support code (hardly anyone uses it anyway). There is not a separate build option to do that, by I think there should be, so: #1953. If you can give that a whirl after doing The real solution is of course to see what |
OpenSSL versions older than 1.1.1 have all been dead for over 4 years. I don't see why an Cyclone would have to continue supporting the bad practice of not updating EOL'd security sensitive libraries full of known vulnerabilities.
Of course nobody should be using OpenSSL 1.1.1 anymore (it has been EOL'd about half a year ago), but I know there are still plenty of systems in the field that rely on it and even the CI on Azure gets the latest Linux images with it pre-installed.
Fixes #1925 — or so I expect anyway. @zhzhzoo-autra I'd appreciate it if you could give it a try.