Merge pull request #25 from eclipse-ecal/service-impl-bug

service implementation nullptr issue
eclipse-ecal · Feb 19, 2024 · c732d17 · c732d17
2 parents 8afed82 + 4312d53
commit c732d17
Showing 1 changed file with 3 additions and 4 deletions.
diff --git a/src/core/src/service/ecal_service_client_impl.cpp b/src/core/src/service/ecal_service_client_impl.cpp
@@ -184,11 +184,10 @@ namespace eCAL
   // blocking call, all responses will be returned in service_response_vec_
   bool CServiceClientImpl::Call(const std::string& method_name_, const std::string& request_, int timeout_ms_, ServiceResponseVecT* service_response_vec_)
   {
-    auto responses = CallBlocking(method_name_, request_, std::chrono::milliseconds(timeout_ms_));
+    if(service_response_vec_ == nullptr) return false;
+    service_response_vec_->clear();
 
-    if (service_response_vec_)
-      service_response_vec_->clear();
-
+    auto responses = CallBlocking(method_name_, request_, std::chrono::milliseconds(timeout_ms_));
     if (!responses)
     {
       return false;