sync with eclipse-ecal #53
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| @@ -137,6 +137,8 @@ namespace eCAL | |||
| } | |||
|
|
|||
| std::string error_s; | |||
| CProtoDynDecoder dyn_decoder; | |||
There was a problem hiding this comment.
warning: variable 'dyn_decoder' is not initialized [cppcoreguidelines-init-variables]
Suggested change
| CProtoDynDecoder dyn_decoder; | |
| CProtoDynDecoder dyn_decoder = 0; |
|
|
||
| private: | ||
| CServiceClientImpl(); | ||
|
|
||
| public: | ||
| ~CServiceClientImpl(); | ||
|
|
||
| bool Create(const std::string& service_name_); | ||
| bool Create(const std::string& service_name_, const ServiceMethodInformationMapT& method_information_map_); |
There was a problem hiding this comment.
warning: function 'eCAL::CServiceClientImpl::Create' has a definition with different parameter names [readability-inconsistent-declaration-parameter-name]
bool Create(const std::string& service_name_, const ServiceMethodInformationMapT& method_information_map_);
^Additional context
ecal/core/src/service/ecal_service_client_impl.cpp:68: the definition seen here
bool CServiceClientImpl::Create(const std::string& service_name_, const ServiceMethodInformationMapT& methods_information_map_)
^ecal/core/src/service/ecal_service_client_impl.h:51: differing parameters are named here: ('method_information_map_'), in definition: ('methods_information_map_')
bool Create(const std::string& service_name_, const ServiceMethodInformationMapT& method_information_map_);
^
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.