sync-with-eclipse-ecal-2024-07-17 #73

rex-schilasky · 2024-07-17T09:04:43Z

sync-with-eclipse-ecal-2024-07-17

github-actions

clang-tidy made some suggestions

There were too many comments to post at once. Showing the first 20 out of 33. Check the log or trigger a new build to see more.

github-actions · 2024-07-17T10:01:30Z

ecal/core/include/ecal/config/configuration.h

+    std::string                      ecal_ini_file_path{};
+
+  private:
+    ECAL_API void Init(std::vector<std::string>& args_);


warning: function 'eCAL::Configuration::Init' has a definition with different parameter names [readability-inconsistent-declaration-parameter-name]

ECAL_API void Init(std::vector<std::string>& args_); ^

Additional context

ecal/core/src/config/ecal_config_initializer.cpp:229: the definition seen here

void Configuration::Init(std::vector<std::string>& arguments_) ^

ecal/core/include/ecal/config/configuration.h:77: differing parameters are named here: ('args_'), in definition: ('arguments_')

ECAL_API void Init(std::vector<std::string>& args_); ^

github-actions · 2024-07-17T10:01:30Z

ecal/core/include/ecal/msg/protobuf/dynamic_json_subscriber.h

@@ -26,13 +26,15 @@

 #include <ecal/ecal.h>


warning: 'ecal/ecal.h' file not found [clang-diagnostic-error]

#include <ecal/ecal.h> ^

github-actions · 2024-07-17T10:01:30Z

ecal/core/include/ecal/msg/protobuf/dynamic_json_subscriber.h

+      class ProtobufDynamicJSONDeserializer
+      {
+      public:
+        std::string Deserialize(const void* buffer_, size_t size_, const SDataTypeInformation& datatype_info_)


warning: method 'Deserialize' can be made static [readability-convert-member-functions-to-static]

Suggested change

std::string Deserialize(const void* buffer_, size_t size_, const SDataTypeInformation& datatype_info_)

static std::string Deserialize(const void* buffer_, size_t size_, const SDataTypeInformation& datatype_info_)

github-actions · 2024-07-17T10:01:30Z

ecal/core/include/ecal/msg/protobuf/dynamic_json_subscriber.h

-      m_msg_callback = callback_;
-      return true;
-    }
+          std::string binary_input;


warning: variable 'binary_input' is not initialized [cppcoreguidelines-init-variables]

Suggested change

std::string binary_input;

std::string binary_input = 0;

github-actions · 2024-07-17T10:01:31Z

ecal/core/include/ecal/msg/protobuf/dynamic_json_subscriber.h

-    }
+          std::string binary_input;
+          binary_input.assign(static_cast<const char*>(buffer_), static_cast<size_t>(size_));
+          std::string json_output;


warning: variable 'json_output' is not initialized [cppcoreguidelines-init-variables]

Suggested change

std::string json_output;

std::string json_output = 0;

github-actions · 2024-07-17T10:01:32Z

ecal/core/src/ecal_global_accessors.cpp

@@ -33,6 +34,7 @@ namespace eCAL
  std::atomic<int>              g_globals_ctx_ref_cnt;

  std::string                   g_default_ini_file(ECAL_DEFAULT_CFG);
+  Configuration                 g_ecal_configuration{};


warning: variable 'g_ecal_configuration' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables]

Configuration g_ecal_configuration{}; ^

github-actions · 2024-07-17T10:01:32Z

ecal/core/src/ecal_global_accessors.cpp

  {
-    return g_globals_ctx;
+    g_globals_ctx = new CGlobals;


warning: assigning newly created 'gsl::owner<>' to non-owner 'CGlobals *' [cppcoreguidelines-owning-memory]

g_globals_ctx = new CGlobals; ^

github-actions · 2024-07-17T10:01:32Z

ecal/core/src/ecal_global_accessors.h

 #endif

  // declaration of globally accessible variables
  extern CGlobals*                     g_globals_ctx;
  extern std::atomic<int>              g_globals_ctx_ref_cnt;

  extern std::string                   g_default_ini_file;
+  extern Configuration                 g_ecal_configuration;


warning: variable 'g_ecal_configuration' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables]

extern Configuration g_ecal_configuration; ^

github-actions · 2024-07-17T10:01:32Z

ecal/core/src/pubsub/ecal_publisher_config.cpp

-    Configuration::Configuration() :
-      share_topic_type(eCAL::Config::IsTopicTypeSharingEnabled()),
-      share_topic_description(eCAL::Config::IsTopicDescriptionSharingEnabled())
+    Configuration::Configuration() 


warning: constructor does not initialize these fields: share_topic_type, share_topic_description [cppcoreguidelines-pro-type-member-init]

ecal/core/include/ecal/config/publisher.h:142:

- bool share_topic_type; //!< share topic type via registration - bool share_topic_description; //!< share topic description via registration + bool share_topic_type{}; //!< share topic type via registration + bool share_topic_description{}; //!< share topic description via registration

github-actions · 2024-07-17T10:01:32Z

ecal/core/src/registration/ecal_registration_provider.cpp

@@ -258,6 +169,12 @@ namespace eCAL
    m_sample_list.samples.clear();
  }

+  void CRegistrationProvider::SendSampleList()
+  {
+    std::lock_guard<std::mutex> lock(m_sample_list_mtx);


warning: variable 'lock' of type 'std::lock_guardstd::mutex' can be declared 'const' [misc-const-correctness]

Suggested change

std::lock_guard<std::mutex> lock(m_sample_list_mtx);

std::lock_guard<std::mutex> const lock(m_sample_list_mtx);

github-actions

clang-tidy made some suggestions

github-actions · 2024-07-17T12:18:21Z

ecal/core/src/registration/ecal_registration_provider.h

-
-    std::shared_ptr<UDP::CSampleSender> m_reg_sample_snd;
-    std::shared_ptr<CCallbackThread>    m_reg_sample_snd_thread;
+    static std::atomic<bool>             m_created;


warning: variable 'm_created' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables]

static std::atomic<bool> m_created; ^

github-actions · 2024-07-17T12:18:21Z

ecal/samples/cpp/monitoring/monitoring_get_topics/src/monitoring_get_topics.cpp


 int main(int argc, char **argv)
 {
-  int                                   run(0), runs(1000);
+  int                                   run(0), runs(10);


warning: multiple declarations in a single statement reduces readability [readability-isolate-declaration]

Suggested change

int run(0), runs(10);

int run(0);

int runs(10);

github-actions · 2024-07-17T12:18:22Z

ecal/tests/cpp/config_test/src/config_test.cpp

+
+  // Transport layer options
+  const bool                drop_out_of_order_messages  = true;
+  std::string               ip_address                  = "238.200.100.2";


warning: variable 'ip_address' of type 'std::string' (aka 'basic_string') can be declared 'const' [misc-const-correctness]

Suggested change

std::string ip_address = "238.200.100.2";

std::string const ip_address = "238.200.100.2";

github-actions · 2024-07-17T12:18:22Z

ecal/tests/cpp/config_test/src/config_test.cpp

+  // test copy method for config structure
+  eCAL::Configuration config1(0, nullptr);
+  eCAL::Configuration config2(0, nullptr);
+  std::string testValue = std::string("234.0.3.2");


warning: variable 'testValue' of type 'std::string' (aka 'basic_string') can be declared 'const' [misc-const-correctness]

Suggested change

std::string testValue = std::string("234.0.3.2");

std::string const testValue = std::string("234.0.3.2");

github-actions · 2024-07-17T12:18:22Z

ecal/tests/cpp/config_test/src/config_test.cpp

+  const std::string reg_to_value = "6000";
+  const std::string reg_rf_value = "1000";
+
+  arguments.push_back("test_config_cmd_parser");


warning: use emplace_back instead of push_back [modernize-use-emplace]

Suggested change

arguments.push_back("test_config_cmd_parser");

arguments.emplace_back("test_config_cmd_parser");

github-actions · 2024-07-17T12:18:22Z

ecal/tests/cpp/expmap_test/src/expmap_test.cpp

+  }
+
+private:
+  static duration current_time;


warning: variable 'current_time' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables]

static duration current_time; ^

github-actions · 2024-07-17T12:18:22Z

ecal/tests/cpp/expmap_test/src/expmap_test.cpp

+};
+
+// Initialize the static member
+TestingClock::duration TestingClock::current_time{ 0 };


warning: variable 'current_time' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables]

TestingClock::duration TestingClock::current_time{ 0 }; ^

github-actions · 2024-07-17T12:18:22Z

ecal/tests/cpp/pubsub_test/src/pubsub_receive_test.cpp

+    auto max_lines(10);
+    auto receive_lambda = [&received, &max_lines](const char* /*topic_name_*/, const struct eCAL::SReceiveCallbackData* data_)
+      {
+        if (max_lines)


warning: implicit conversion 'int' -> bool [readability-implicit-bool-conversion]

Suggested change

if (max_lines)

if (max_lines != 0)

github-actions · 2024-07-17T12:18:23Z

ecal/tests/cpp/util_test/src/util_test.cpp

+  long long time_point;
+};
+
+std::vector<command> commands =


warning: variable 'commands' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables]

std::vector<command> commands = ^

github-actions · 2024-07-17T12:18:23Z

ecal/tests/cpp/util_test/src/util_test.cpp

+
+  for (const auto& command : commands)
+  {
+    std::chrono::steady_clock::time_point time(std::chrono::milliseconds(command.time_point));


warning: variable 'time' of type 'std::chrono::steady_clock::time_point' (aka 'time_point<std::chrono::steady_clock, duration<long, ratio<1, 1000000000>>>') can be declared 'const' [misc-const-correctness]

Suggested change

std::chrono::steady_clock::time_point time(std::chrono::milliseconds(command.time_point));

std::chrono::steady_clock::time_point const time(std::chrono::milliseconds(command.time_point));

rex-schilasky added 3 commits July 17, 2024 11:03

sync-with-eclipse-ecal-2024-07-17

1b9dee5

boolean return

9a54764

small adaptions

e911e27

github-actions bot reviewed Jul 17, 2024

View reviewed changes

rex-schilasky added 4 commits July 17, 2024 12:48

configuration fixed for publisher/subcriber definitions

ce076d0

partly reverted

48bd168

pub/sub config included in build

6eedea0

test should work independently

07f4cfe

rex-schilasky merged commit 25e4785 into main Jul 17, 2024
81 of 82 checks passed

rex-schilasky deleted the sync-with-eclipse-ecal-2024-07-17 branch July 17, 2024 12:15

github-actions bot reviewed Jul 17, 2024

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

sync-with-eclipse-ecal-2024-07-17 #73

sync-with-eclipse-ecal-2024-07-17 #73

rex-schilasky commented Jul 17, 2024

github-actions bot left a comment

github-actions bot Jul 17, 2024

github-actions bot Jul 17, 2024

github-actions bot Jul 17, 2024

github-actions bot Jul 17, 2024

github-actions bot Jul 17, 2024

github-actions bot Jul 17, 2024

github-actions bot Jul 17, 2024

github-actions bot Jul 17, 2024

github-actions bot Jul 17, 2024

github-actions bot Jul 17, 2024

github-actions bot left a comment

github-actions bot Jul 17, 2024

github-actions bot Jul 17, 2024

github-actions bot Jul 17, 2024

github-actions bot Jul 17, 2024

github-actions bot Jul 17, 2024

github-actions bot Jul 17, 2024

github-actions bot Jul 17, 2024

github-actions bot Jul 17, 2024

github-actions bot Jul 17, 2024

github-actions bot Jul 17, 2024

	std::string Deserialize(const void* buffer_, size_t size_, const SDataTypeInformation& datatype_info_)
	static std::string Deserialize(const void* buffer_, size_t size_, const SDataTypeInformation& datatype_info_)

	std::lock_guard<std::mutex> lock(m_sample_list_mtx);
	std::lock_guard<std::mutex> const lock(m_sample_list_mtx);

	std::string ip_address = "238.200.100.2";
	std::string const ip_address = "238.200.100.2";

	std::string testValue = std::string("234.0.3.2");
	std::string const testValue = std::string("234.0.3.2");

	arguments.push_back("test_config_cmd_parser");
	arguments.emplace_back("test_config_cmd_parser");

	std::chrono::steady_clock::time_point time(std::chrono::milliseconds(command.time_point));
	std::chrono::steady_clock::time_point const time(std::chrono::milliseconds(command.time_point));

sync-with-eclipse-ecal-2024-07-17 #73

sync-with-eclipse-ecal-2024-07-17 #73

Conversation

rex-schilasky commented Jul 17, 2024

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot Jul 17, 2024

Choose a reason for hiding this comment

github-actions bot Jul 17, 2024

Choose a reason for hiding this comment

github-actions bot Jul 17, 2024

Choose a reason for hiding this comment

github-actions bot Jul 17, 2024

Choose a reason for hiding this comment

github-actions bot Jul 17, 2024

Choose a reason for hiding this comment

github-actions bot Jul 17, 2024

Choose a reason for hiding this comment

github-actions bot Jul 17, 2024

Choose a reason for hiding this comment

github-actions bot Jul 17, 2024

Choose a reason for hiding this comment

github-actions bot Jul 17, 2024

Choose a reason for hiding this comment

github-actions bot Jul 17, 2024

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot Jul 17, 2024

Choose a reason for hiding this comment

github-actions bot Jul 17, 2024

Choose a reason for hiding this comment

github-actions bot Jul 17, 2024

Choose a reason for hiding this comment

github-actions bot Jul 17, 2024

Choose a reason for hiding this comment

github-actions bot Jul 17, 2024

Choose a reason for hiding this comment

github-actions bot Jul 17, 2024

Choose a reason for hiding this comment

github-actions bot Jul 17, 2024

Choose a reason for hiding this comment

github-actions bot Jul 17, 2024

Choose a reason for hiding this comment

github-actions bot Jul 17, 2024

Choose a reason for hiding this comment

github-actions bot Jul 17, 2024

Choose a reason for hiding this comment