Skip to content

Commit

Permalink
CDataWriterSHM::RemLocConnection removed (this function makes no sense)
Browse files Browse the repository at this point in the history
  • Loading branch information
rex-schilasky committed Oct 23, 2023
1 parent 6687670 commit 850cbf3
Showing 1 changed file with 0 additions and 22 deletions.
22 changes: 0 additions & 22 deletions ecal/core/src/readwrite/ecal_writer_shm.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -190,28 +190,6 @@ namespace eCAL
return ret_state;
}

bool CDataWriterSHM::RemLocConnection(const std::string& process_id_)
{
if (!m_created) return false;
bool ret_state(true);

for (auto& memory_file : m_memory_file_vec)
{
// This is not working correctly under POSIX for memory files that are read and written within the same process.
//
// The functions 'CSyncMemoryFile::Disconnect' and 'CDataWriterSHM::RemLocConnection' are now called
// by the new Subscriber Unregistration event logic and were never called in any previous eCAL version.
//
// TODO: Fix this in 'CSyncMemoryFile::Disconnect' to handle event resources properly.
if (std::to_string(eCAL::Process::GetProcessID()) != process_id_)
{
ret_state &= memory_file->Disconnect(process_id_);
}
}

return ret_state;
}

std::string CDataWriterSHM::GetConnectionParameter()
{
// starting from eCAL version > 5.8.13/5.9.0 the ConnectionParameter is defined as google protobuf
Expand Down

0 comments on commit 850cbf3

Please sign in to comment.