[core] redesign service server api (#1849)

eclipse-ecal · Dec 13, 2024 · 9cdfe52 · 9cdfe52
1 parent d7a868b
commit 9cdfe52
Show file tree

Hide file tree

Showing 47 changed files with 1,414 additions and 1,052 deletions.
diff --git a/ecal/core/CMakeLists.txt b/ecal/core/CMakeLists.txt
@@ -389,6 +389,9 @@ if(ECAL_CORE_SERVICE)
       src/service/ecal_service_server.cpp
       src/service/ecal_service_server_impl.cpp
       src/service/ecal_service_server_impl.h
+      src/service/ecal_service_server_v5.cpp
+      src/service/ecal_service_server_v5_impl.cpp
+      src/service/ecal_service_server_v5_impl.h
       src/service/ecal_service_singleton_manager.cpp
       src/service/ecal_service_singleton_manager.h
   )
@@ -511,7 +514,6 @@ set(ecal_header_cmn
     include/ecal/config/monitoring.h
     include/ecal/config/publisher.h
     include/ecal/config/registration.h
-    include/ecal/config/service.h
     include/ecal/config/subscriber.h
     include/ecal/config/time.h
     include/ecal/config/transport_layer.h
@@ -537,6 +539,7 @@ set(ecal_header_cmn
     include/ecal/ecal_registration.h
     include/ecal/ecal_publisher.h
     include/ecal/ecal_server.h
+    include/ecal/ecal_server_v5.h
     include/ecal/ecal_service_info.h
     include/ecal/ecal_subscriber.h
     include/ecal/ecal_time.h

diff --git a/ecal/core/include/ecal/config/configuration.h b/ecal/core/include/ecal/config/configuration.h
@@ -27,7 +27,6 @@
 #include <ecal/config/application.h>
 #include <ecal/config/monitoring.h>
 #include <ecal/config/registration.h>
-#include <ecal/config/service.h>
 #include <ecal/config/logging.h>
 #include <ecal/config/user_arguments.h>
 #include <ecal/config/publisher.h>
@@ -54,7 +53,6 @@ namespace eCAL
     Subscriber::Configuration     subscriber;
     Publisher::Configuration      publisher;
     Time::Configuration           timesync;
-    Service::Configuration        service;
     Application::Configuration    application;
     Logging::Configuration        logging;
     Cli::Configuration            command_line_arguments;

diff --git a/ecal/core/include/ecal/config/service.h b/ecal/core/include/ecal/config/service.h
diff --git a/ecal/core/include/ecal/ecal_client.h b/ecal/core/include/ecal/ecal_client.h
@@ -26,9 +26,11 @@
 
 #include <ecal/ecal_deprecate.h>
 #include <ecal/ecal_os.h>
+
 #include <ecal/ecal_callback.h>
-#include <ecal/ecal_service_info.h>
 #include <ecal/ecal_client_instance.h>
+#include <ecal/ecal_service_info.h>
+#include <ecal/ecal_types.h>
 
 #include <memory>
 #include <string>
@@ -62,13 +64,27 @@ namespace eCAL
       ECAL_API_EXPORTED_MEMBER
         virtual ~CServiceClient();
 
-      // Deleted copy constructor and copy assignment operator
+      /**
+       * @brief CServiceClient are non-copyable
+      **/
       CServiceClient(const CServiceClient&) = delete;
+
+      /**
+       * @brief CServiceClient are non-copyable
+      **/
       CServiceClient& operator=(const CServiceClient&) = delete;
 
-      // Move constructor and move assignment operator
-      ECAL_API_EXPORTED_MEMBER CServiceClient(CServiceClient&& rhs) noexcept;
-      ECAL_API_EXPORTED_MEMBER CServiceClient& operator=(CServiceClient&& rhs) noexcept;
+      /**
+       * @brief CServiceClient are move-enabled
+      **/
+      ECAL_API_EXPORTED_MEMBER
+        CServiceClient(CServiceClient&& rhs) noexcept;
+
+      /**
+       * @brief CServiceClient are move-enabled
+      **/
+      ECAL_API_EXPORTED_MEMBER
+        CServiceClient& operator=(CServiceClient&& rhs) noexcept;
 
       /**
        * @brief Get the client instances for all matching services
@@ -124,6 +140,17 @@ namespace eCAL
       ECAL_API_EXPORTED_MEMBER
         std::string GetServiceName() const;
 
+      /**
+       * @brief Retrieve the service id.
+       *
+       * @return  The service id.
+      **/
+
+      // TODO: Implement this
+
+      ECAL_API_EXPORTED_MEMBER
+        Registration::SServiceMethodId GetServiceId() const;
+
       /**
        * @brief Check connection to at least one service.
        *
@@ -136,4 +163,4 @@ namespace eCAL
       std::shared_ptr<eCAL::CServiceClientImpl> m_service_client_impl;
     };
   }
-}
+}
diff --git a/ecal/core/include/ecal/ecal_client_v5.h b/ecal/core/include/ecal/ecal_client_v5.h
@@ -214,7 +214,7 @@ namespace eCAL
       ECAL_API_EXPORTED_MEMBER
         bool IsConnected();
 
-    protected:
+    private:
       std::shared_ptr<CServiceClientImpl> m_service_client_impl;
     };
   }

diff --git a/ecal/core/include/ecal/ecal_config.h b/ecal/core/include/ecal/ecal_config.h
@@ -33,7 +33,6 @@ namespace eCAL
   ECAL_API Configuration&                 GetConfiguration                 ();
   ECAL_API Subscriber::Configuration&     GetSubscriberConfiguration       ();
   ECAL_API Publisher::Configuration&      GetPublisherConfiguration        ();
-  ECAL_API Service::Configuration&        GetServiceConfiguration          ();
 
   namespace Config
   {
@@ -103,18 +102,14 @@ namespace eCAL
     /////////////////////////////////////
     // publisher
     /////////////////////////////////////
+
     ECAL_API bool                     IsTopicTypeSharingEnabled            ();
     ECAL_API bool                     IsTopicDescriptionSharingEnabled     ();
-
-    /////////////////////////////////////
-    // service
-    /////////////////////////////////////
-    ECAL_API bool                     IsServiceProtocolV0Enabled           ();
-    ECAL_API bool                     IsServiceProtocolV1Enabled           ();
 
     /////////////////////////////////////
     // subscriber
     /////////////////////////////////////
+
     ECAL_API bool                     GetDropOutOfOrderMessages            ();
 
     /////////////////////////////////////