feature/udp-receive-thread-timing-configuration #1262
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
There was one hardcoded udp sample receive timeout parameter of 10 ms inside
CSampleReceiver::Receive
. This function is used in 3 different receive threads for registration, logging and payload udp sample receiving. This internal parameter is now replaced by a function parameter and can be configured inecal_def.h
.They are adapted from 10 ms to 1000 ms. This will not lead to any new functional behavior except the the graceful shutdown of an eCAL node can take up to 1000 ms in theory.
Furthermore, there is a rarely used functionality of the CSubscriber API (
CSubscriber::SetTimeout(int timeout_)
) to define a timeout for incoming payload messages (independent from the transport layer). The resolution can be configured by the ecal_def.h parameterCMN_DATAREADER_TIMEOUT_RESOLUTION_MS
. This parameter is now changed from 10 ms to 100 ms to decrease the cpu load of this test logic.Summary:
Related issues
Related to #1236
Cherry-pick to