[Python] Added BinarySubscriber and BinaryPublisher with examples #1526
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hannemn
reviewed
Apr 12, 2024
|
|
||
| find_package(eCAL REQUIRED) | ||
|
|
||
| set(PROJECT_GROUP minimal) |
There was a problem hiding this comment.
PROJECT_GROUP should be "binary" here
hannemn
reviewed
Apr 12, 2024
| while ecal_core.ok(): | ||
| ret, msg, time = sub.receive(500) | ||
| if ret > 0: | ||
| print("Received: {} ms {}".format(time, msg)) |
There was a problem hiding this comment.
Embedding the binary into a regular doesn't look very pretty as non-printable characters will be escaped with leading backslashes which make it looks kind of messy . Maybe a hexadecimal representation would be better here such as "FF EE CC 1A".
hannemn
reviewed
Apr 12, 2024
|
|
||
| find_package(eCAL REQUIRED) | ||
|
|
||
| set(PROJECT_GROUP minimal) |
hannemn
reviewed
Apr 12, 2024
|
|
||
| # eCAL receive callback | ||
| def callback(topic_name, msg, time): | ||
| print("Received: {} ms {}".format(time, msg)) |
There was a problem hiding this comment.
Same here with embedded binary data.
hannemn
reviewed
Apr 12, 2024
|
|
||
| find_package(eCAL REQUIRED) | ||
|
|
||
| set(PROJECT_GROUP minimal) |
hannemn
reviewed
Apr 12, 2024
| # send messages | ||
| staticmsg = msg | ||
| while ecal_core.ok(): | ||
| pub.send(msg) |
There was a problem hiding this comment.
The first send iteration should already contain the random binary array.
hannemn
requested changes
Apr 12, 2024
FlorianReimold
approved these changes
Apr 30, 2024
hannemn
approved these changes
Apr 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I added a BinarySubscriber and a BinaryPublisher class to the Python wheel. Now you can send binary data using Python
Related issues
Cherry-pick to