[build] make eCAL::proto part of ecal subfolder (ecal_core project) #1528
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
KerstinKeller
commented
Apr 15, 2024
KerstinKeller
commented
- changed include folder from "ecal/protobuf/..." to "ecal/msg/protobuf/..." to be in line with the includes from core (e.g. subscriber.h / publisher.h)
- target naming: eCAL::core_protobuf to be discussed.
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| @@ -28,7 +28,7 @@ | |||
| #pragma warning(pop) | |||
| #endif | |||
|
|
|||
| #include <ecal/protobuf/ecal_proto_hlp.h> | |||
| #include <ecal/msg/protobuf/ecal_proto_hlp.h> | |||
| #include <ecal/msg/message.h> | |||
There was a problem hiding this comment.
warning: 'ecal/msg/message.h' file not found [clang-diagnostic-error]
#include <ecal/msg/message.h>
^
KerstinKeller
commented
Apr 16, 2024
- changed include folder from "ecal/protobuf/..." to "ecal/msg/protobuf/..." to be in line with the includes from core (e.g. subscriber.h / publisher.h)
KerstinKeller
force-pushed
the
hotfix/ecal_protobuf_target
branch
from
53e25f9 to
6b0a6aa
Compare
rex-schilasky
approved these changes
Apr 16, 2024
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.