Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GH Actions] Removed Code-sign action with self-signed certificate #1560

Merged
merged 1 commit into from
Apr 24, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 0 additions & 29 deletions .github/workflows/build-windows.yml
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@ on:
branches:
- master
env:
IS_GITHUB_SIGNING_ALLOWED: true
IS_JENKINS_SIGNING_ALLOWED: true

jobs:
Expand Down Expand Up @@ -261,34 +260,6 @@ jobs:
run: cpack -C Release
working-directory: ${{ runner.workspace }}/_build/complete

- name: Detect certificate
id: cert
if: env.IS_GITHUB_SIGNING_ALLOWED == 'true'
run: |
if ($Env:CERT_BODY -and $Env:CERT_PSWD -and $Env:CERT_ALGO -and $Env:CERT_HASH) {
Write-Output "ATTENTION: a certificate is available"
Write-Output "IS_GITHUB_SIGNING_ENABLED=true" | Out-File -FilePath $Env:GITHUB_ENV -Encoding utf8 -Append
} else {
Write-Output "WARNING: a certificate is not available"
}
env:
CERT_BODY: ${{ secrets.CERT_BODY }}
CERT_PSWD: ${{ secrets.CERT_PSWD }}
CERT_ALGO: ${{ secrets.CERT_ALGO }}
CERT_HASH: ${{ secrets.CERT_HASH }}

# https://github.com/OrhanKupusoglu/code-sign-action
- name: Sign the installer
if: env.IS_GITHUB_SIGNING_ENABLED == 'true'
uses: OrhanKupusoglu/[email protected]
with:
cert_body: ${{ secrets.CERT_BODY }}
cert_pswd: ${{ secrets.CERT_PSWD }}
cert_algo: ${{ secrets.CERT_ALGO }}
cert_hash: ${{ secrets.CERT_HASH }}
folder: ${{ runner.workspace }}/_build/complete/_deploy
debug: false

- name: Upload Windows setup
uses: actions/upload-artifact@v4
with:
Expand Down
Loading