Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Core, Services, Protobuf] Fixed compatibility with Ubuntu 18.04 (gcc7 / protobuf 3.0) #1592

Merged
merged 1 commit into from
May 15, 2024
Merged

[Core, Services, Protobuf] Fixed compatibility with Ubuntu 18.04 (gcc7 / protobuf 3.0) #1592

merged 1 commit into from
May 15, 2024

Conversation

FlorianReimold
Copy link
Member

Description

  • fixed lambda caputres (not sure why I had to do that in those places but not in others)
  • Removed reserved fields from protobuf enums

@FlorianReimold FlorianReimold added the cherry-pick-to-NONE Don't cherry-pick these changes label May 15, 2024
rex-schilasky
rex-schilasky approved these changes May 15, 2024
View reviewed changes
Copy link
Contributor

@rex-schilasky rex-schilasky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@FlorianReimold FlorianReimold merged commit 9c0bc13 into master May 15, 2024
20 checks passed
@KerstinKeller KerstinKeller deleted the hotfix/gcc7_fixes branch October 2, 2024 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rex-schilasky rex-schilasky rex-schilasky approved these changes

@KerstinKeller KerstinKeller Awaiting requested review from KerstinKeller

Assignees
No one assigned
Labels
cherry-pick-to-NONE Don't cherry-pick these changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@FlorianReimold @rex-schilasky