[core] add/improved IsPublished/IsSubscribed logic (master) #1633
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…IsSubscribed" (we may rename both functions to "IsConnected" in the future) new additional check for IsPublished using the connection state of the matching subscriber (should ensure that IsPublished is flagged as true only if publisher is able to send data) test added to test new behavior
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| @@ -216,3 +216,97 @@ TEST(core_cpp_pubsub, SporadicEmptyReceives) | |||
| // finalize eCAL API | |||
| EXPECT_EQ(0, eCAL::Finalize()); | |||
| } | |||
|
|
|||
| TEST(PubSub, TestSubscriberSeen) | |||
There was a problem hiding this comment.
warning: all parameters should be named in a function [readability-named-parameter]
Suggested change
| TEST(PubSub, TestSubscriberSeen) | |
| TEST(PubSub /*unused*/, TestSubscriberSeen /*unused*/) |
| auto max_lines(10); | ||
| auto receive_lambda = [&received, &max_lines](const char* /*topic_name_*/, const struct eCAL::SReceiveCallbackData* data_) | ||
| { | ||
| if (max_lines) |
There was a problem hiding this comment.
warning: implicit conversion 'int' -> bool [readability-implicit-bool-conversion]
Suggested change
| if (max_lines) | |
| if (max_lines != 0) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related issues